2020-07-08 04:49:47

by Florian Fainelli

Subject: [PATCH net-next] net: dsa: loop: Print when registration is successful

We have a number of error conditions that can lead to the driver not
probing successfully, move the print when we are sure
dsa_register_switch() has suceeded. This avoids repeated prints in case
of probe deferral for instance.

Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/net/dsa/dsa_loop.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index 400207c5c7de..f8bc85a6e670 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -280,13 +280,11 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
struct dsa_loop_pdata *pdata = mdiodev->dev.platform_data;
struct dsa_loop_priv *ps;
struct dsa_switch *ds;
+ int ret;

if (!pdata)
return -ENODEV;

- dev_info(&mdiodev->dev, "%s: 0x%0x\n",
- pdata->name, pdata->enabled_ports);
-
ds = devm_kzalloc(&mdiodev->dev, sizeof(*ds), GFP_KERNEL);
if (!ds)
return -ENOMEM;
@@ -311,7 +309,12 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)

dev_set_drvdata(&mdiodev->dev, ds);

- return dsa_register_switch(ds);
+ ret = dsa_register_switch(ds);
+ if (!ret)
+ dev_info(&mdiodev->dev, "%s: 0x%0x\n",
+ pdata->name, pdata->enabled_ports);
+
+ return ret;
}

static void dsa_loop_drv_remove(struct mdio_device *mdiodev)
--
2.25.1

2020-07-08 13:00:59

by Andrew Lunn

Subject: Re: [PATCH net-next] net: dsa: loop: Print when registration is successful

On Tue, Jul 07, 2020 at 09:45:13PM -0700, Florian Fainelli wrote:
> We have a number of error conditions that can lead to the driver not
> probing successfully, move the print when we are sure
> dsa_register_switch() has suceeded. This avoids repeated prints in case
> of probe deferral for instance.
>
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-07-08 15:41:55

by Vivien Didelot

Subject: Re: [PATCH net-next] net: dsa: loop: Print when registration is successful

On Tue, 7 Jul 2020 21:45:13 -0700, Florian Fainelli <[email protected]> wrote:
> We have a number of error conditions that can lead to the driver not
> probing successfully, move the print when we are sure
> dsa_register_switch() has suceeded. This avoids repeated prints in case
> of probe deferral for instance.
>
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Vivien Didelot <[email protected]>

2020-07-08 17:38:01

by David Miller

Subject: Re: [PATCH net-next] net: dsa: loop: Print when registration is successful

From: Florian Fainelli <[email protected]>
Date: Tue, 7 Jul 2020 21:45:13 -0700

> We have a number of error conditions that can lead to the driver not
> probing successfully, move the print when we are sure
> dsa_register_switch() has suceeded. This avoids repeated prints in case
> of probe deferral for instance.
>
> Signed-off-by: Florian Fainelli <[email protected]>

Applied.