2020-07-03 06:15:51

by Chanwoo Choi

Subject: [RFC PATCH 2/2] memory: samsung: exynos5422-dmc: Use delayed timer as default

Use delayed timer as default instead of deferrable timer
in order to monitor the DMC status regardless of CPU idle.

Signed-off-by: Chanwoo Choi <[email protected]>
---
drivers/memory/samsung/exynos5422-dmc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 25196d6268e2..93e9c2429c0d 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -945,6 +945,7 @@ static int exynos5_dmc_get_cur_freq(struct device *dev, unsigned long *freq)
* It provides to the devfreq framework needed functions and polling period.
*/
static struct devfreq_dev_profile exynos5_dmc_df_profile = {
+ .timer = DEVFREQ_TIMER_DELAYED,
.target = exynos5_dmc_target,
.get_dev_status = exynos5_dmc_get_status,
.get_cur_freq = exynos5_dmc_get_cur_freq,
--
2.17.1

2020-07-08 12:34:55

by Krzysztof Kozlowski

Subject: Re: [RFC PATCH 2/2] memory: samsung: exynos5422-dmc: Use delayed timer as default

On Fri, Jul 03, 2020 at 03:26:22PM +0900, Chanwoo Choi wrote:
> Use delayed timer as default instead of deferrable timer
> in order to monitor the DMC status regardless of CPU idle.
>
> Signed-off-by: Chanwoo Choi <[email protected]>
> ---
> drivers/memory/samsung/exynos5422-dmc.c | 1 +
> 1 file changed, 1 insertion(+)

If you want to take this through devfreq tree, I'm fine:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Otherwise I could grab it through samsung-soc after devfreq change ends
in mainline.

Best regards,
Krzysztof

2020-07-09 05:35:56

by Chanwoo Choi

Subject: Re: [RFC PATCH 2/2] memory: samsung: exynos5422-dmc: Use delayed timer as default

Hi Krzysztof,

On 7/8/20 9:33 PM, Krzysztof Kozlowski wrote:
> On Fri, Jul 03, 2020 at 03:26:22PM +0900, Chanwoo Choi wrote:
>> Use delayed timer as default instead of deferrable timer
>> in order to monitor the DMC status regardless of CPU idle.
>>
>> Signed-off-by: Chanwoo Choi <[email protected]>
>> ---
>> drivers/memory/samsung/exynos5422-dmc.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> If you want to take this through devfreq tree, I'm fine:
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

OK. I'll take it to devfreq-next for v5.9-rc1. Thanks.

>
> Otherwise I could grab it through samsung-soc after devfreq change ends
> in mainline.
>
> Best regards,
> Krzysztof
>
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics