2020-07-09 08:09:52

by Xu Wang

Subject: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()

Remove extra brackets.

Signed-off-by: Xu Wang <[email protected]>
---
tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c
index c565546e85bc..52f3e70b5c81 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixmap.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixmap.c
@@ -70,7 +70,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
fd = open(SYSTEM_MEMORY, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "Cannot open %s\n", SYSTEM_MEMORY);
- return (NULL);
+ return NULL;
}

/* Align the offset to use mmap */
@@ -85,7 +85,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
if (mapped_memory == MAP_FAILED) {
fprintf(stderr, "Cannot map %s\n", SYSTEM_MEMORY);
close(fd);
- return (NULL);
+ return NULL;
}

close(fd);
--
2.17.1

2020-07-09 14:52:18

by Moore, Robert

Subject: RE: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()

- return (NULL);
+ return NULL;

This is the ACPICA coding standard, and it does not affect anything.
Bob

-----Original Message-----
From: Xu Wang <[email protected]>
Sent: Thursday, July 09, 2020 1:08 AM
To: Moore, Robert <[email protected]>; Kaneda, Erik <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]
Subject: [PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()

Remove extra brackets.

Signed-off-by: Xu Wang <[email protected]>
---
tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c
index c565546e85bc..52f3e70b5c81 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixmap.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixmap.c
@@ -70,7 +70,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
fd = open(SYSTEM_MEMORY, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "Cannot open %s\n", SYSTEM_MEMORY);
- return (NULL);
+ return NULL;
}

/* Align the offset to use mmap */
@@ -85,7 +85,7 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
if (mapped_memory == MAP_FAILED) {
fprintf(stderr, "Cannot map %s\n", SYSTEM_MEMORY);
close(fd);
- return (NULL);
+ return NULL;
}

close(fd);
--
2.17.1