2020-07-10 16:06:23

by Melissa Wen

[permalink] [raw]

Subject: [PATCH] drm/vkms: change the max cursor width/height

---

This change expands the coverage for the IGT kms_cursor_crc test, where
the size varies between 64 and 512 for a square cursor. With this, in
addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.

Signed-off-by: Melissa Wen <[email protected]>
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 1e8b2169d834..57a8a397d5e8 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
dev->mode_config.min_height = YRES_MIN;
dev->mode_config.max_width = XRES_MAX;
dev->mode_config.max_height = YRES_MAX;
+ dev->mode_config.cursor_width = 512;
+ dev->mode_config.cursor_height = 512;
dev->mode_config.preferred_depth = 24;
dev->mode_config.helper_private = &vkms_mode_config_helpers;

--
2.27.0

2020-07-12 22:06:18

by Rodrigo Siqueira

[permalink] [raw]

Subject: Re: [PATCH] drm/vkms: change the max cursor width/height

---

Hi Melissa,

First of all, thanks a lot for your patch! This is a nice change since
it increases the code coverage.

Reviewed-by: Rodrigo Siqueira <[email protected]>

On 07/10, Melissa Wen wrote:
> This change expands the coverage for the IGT kms_cursor_crc test, where
> the size varies between 64 and 512 for a square cursor. With this, in
> addition to the cursor 64x64, this patch enables the test of cursors with
> sizes: 128x128, 256x256, and 512x512.
>
> Signed-off-by: Melissa Wen <[email protected]>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 1e8b2169d834..57a8a397d5e8 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> dev->mode_config.min_height = YRES_MIN;
> dev->mode_config.max_width = XRES_MAX;
> dev->mode_config.max_height = YRES_MAX;
> + dev->mode_config.cursor_width = 512;
> + dev->mode_config.cursor_height = 512;
> dev->mode_config.preferred_depth = 24;
> dev->mode_config.helper_private = &vkms_mode_config_helpers;
>
> --
> 2.27.0
>

--
Rodrigo Siqueira
https://siqueira.tech

---

Attachments:

(No filename) (1.29 kB)
signature.asc (849.00 B)
Download all attachments

2020-07-12 22:12:22

by Rodrigo Siqueira

[permalink] [raw]

Subject: Re: [PATCH] drm/vkms: change the max cursor width/height

---

Applied to drm-misc-next.

Thanks

On 07/12, Rodrigo Siqueira wrote:
> Hi Melissa,
>
> First of all, thanks a lot for your patch! This is a nice change since
> it increases the code coverage.
>
> Reviewed-by: Rodrigo Siqueira <[email protected]>
>
> On 07/10, Melissa Wen wrote:
> > This change expands the coverage for the IGT kms_cursor_crc test, where
> > the size varies between 64 and 512 for a square cursor. With this, in
> > addition to the cursor 64x64, this patch enables the test of cursors with
> > sizes: 128x128, 256x256, and 512x512.
> >
> > Signed-off-by: Melissa Wen <[email protected]>
> > ---
> > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 1e8b2169d834..57a8a397d5e8 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> > dev->mode_config.min_height = YRES_MIN;
> > dev->mode_config.max_width = XRES_MAX;
> > dev->mode_config.max_height = YRES_MAX;
> > + dev->mode_config.cursor_width = 512;
> > + dev->mode_config.cursor_height = 512;
> > dev->mode_config.preferred_depth = 24;
> > dev->mode_config.helper_private = &vkms_mode_config_helpers;
> >
> > --
> > 2.27.0
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech



--
Rodrigo Siqueira
https://siqueira.tech

---

Attachments:

(No filename) (1.49 kB)
signature.asc (849.00 B)
Download all attachments