2020-06-19 09:10:35

by Biwen Li (OSS)

Subject: [PATCH] dts: arm64: lx2160a-rdb: fix shunt-resistor

From: Biwen Li <[email protected]>

Fix value of shunt-resistor property

Signed-off-by: Biwen Li <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
index e266d8a170ea..dce79018d397 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
@@ -141,7 +141,7 @@
power-monitor@40 {
compatible = "ti,ina220";
reg = <0x40>;
- shunt-resistor = <1000>;
+ shunt-resistor = <500>;
};
};

--
2.17.1

2020-07-11 13:56:55

by Shawn Guo

Subject: Re: [PATCH] dts: arm64: lx2160a-rdb: fix shunt-resistor

On Fri, Jun 19, 2020 at 04:46:07PM +0800, Biwen Li wrote:
> From: Biwen Li <[email protected]>
>
> Fix value of shunt-resistor property
>
> Signed-off-by: Biwen Li <[email protected]>

'arm64: dts: ...' as subject prefix please.

Also can you improve commit log to better describe the problem the patch
is fixing?

Shawn

> ---
> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index e266d8a170ea..dce79018d397 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -141,7 +141,7 @@
> power-monitor@40 {
> compatible = "ti,ina220";
> reg = <0x40>;
> - shunt-resistor = <1000>;
> + shunt-resistor = <500>;
> };
> };
>
> --
> 2.17.1
>

2020-07-14 06:53:23

by Biwen Li (OSS)

Subject: RE: [PATCH] dts: arm64: lx2160a-rdb: fix shunt-resistor

> On Fri, Jun 19, 2020 at 04:46:07PM +0800, Biwen Li wrote:
> > From: Biwen Li <[email protected]>
> >
> > Fix value of shunt-resistor property
> >
> > Signed-off-by: Biwen Li <[email protected]>
>
> 'arm64: dts: ...' as subject prefix please.
>
> Also can you improve commit log to better describe the problem the patch is
> fixing?
Sure, will update in v2.
>
> Shawn
>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > index e266d8a170ea..dce79018d397 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > @@ -141,7 +141,7 @@
> > power-monitor@40 {
> > compatible = "ti,ina220";
> > reg = <0x40>;
> > - shunt-resistor = <1000>;
> > + shunt-resistor = <500>;
> > };
> > };
> >
> > --
> > 2.17.1
> >