2020-07-13 20:08:41

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] udf: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
(Actually letting a shell for loop submit all this stuff for me.)

If there are any URLs to be removed completely or at least not just HTTPSified:
Just clearly say so and I'll *undo my change*.
See also: https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See: https://lkml.org/lkml/2020/6/26/837

If you apply the patch, please let me know.

Sorry again to all maintainers who complained about subject lines.
Now I realized that you want an actually perfect prefixes,
not just subsystem ones.
I tried my best...
And yes, *I could* (at least half-)automate it.
Impossible is nothing! :)


Documentation/filesystems/udf.rst | 2 +-
fs/udf/ecma_167.h | 2 +-
fs/udf/super.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/filesystems/udf.rst b/Documentation/filesystems/udf.rst
index d9badbf285b2..f9489ddbb767 100644
--- a/Documentation/filesystems/udf.rst
+++ b/Documentation/filesystems/udf.rst
@@ -72,4 +72,4 @@ For the latest version and toolset see:

Documentation on UDF and ECMA 167 is available FREE from:
- http://www.osta.org/
- - http://www.ecma-international.org/
+ - https://www.ecma-international.org/
diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
index 736ebc5dc441..185c3e247648 100644
--- a/fs/udf/ecma_167.h
+++ b/fs/udf/ecma_167.h
@@ -2,7 +2,7 @@
* ecma_167.h
*
* This file is based on ECMA-167 3rd edition (June 1997)
- * http://www.ecma.ch
+ * https://www.ecma.ch
*
* Copyright (c) 2001-2002 Ben Fennema
* Copyright (c) 2017-2019 Pali Rohár <[email protected]>
diff --git a/fs/udf/super.c b/fs/udf/super.c
index f747bf72edbe..1c42f544096d 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -11,8 +11,8 @@
* This code is based on version 2.00 of the UDF specification,
* and revision 3 of the ECMA 167 standard [equivalent to ISO 13346].
* http://www.osta.org/
- * http://www.ecma.ch/
- * http://www.iso.org/
+ * https://www.ecma.ch/
+ * https://www.iso.org/
*
* COPYRIGHT
* This file is distributed under the terms of the GNU General Public
--
2.27.0


2020-07-14 12:40:46

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] udf: Replace HTTP links with HTTPS ones

On Mon 13-07-20 22:07:38, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>

Thanks. I've queued the patch to my tree.

Honza

> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not just HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> Documentation/filesystems/udf.rst | 2 +-
> fs/udf/ecma_167.h | 2 +-
> fs/udf/super.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/filesystems/udf.rst b/Documentation/filesystems/udf.rst
> index d9badbf285b2..f9489ddbb767 100644
> --- a/Documentation/filesystems/udf.rst
> +++ b/Documentation/filesystems/udf.rst
> @@ -72,4 +72,4 @@ For the latest version and toolset see:
>
> Documentation on UDF and ECMA 167 is available FREE from:
> - http://www.osta.org/
> - - http://www.ecma-international.org/
> + - https://www.ecma-international.org/
> diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
> index 736ebc5dc441..185c3e247648 100644
> --- a/fs/udf/ecma_167.h
> +++ b/fs/udf/ecma_167.h
> @@ -2,7 +2,7 @@
> * ecma_167.h
> *
> * This file is based on ECMA-167 3rd edition (June 1997)
> - * http://www.ecma.ch
> + * https://www.ecma.ch
> *
> * Copyright (c) 2001-2002 Ben Fennema
> * Copyright (c) 2017-2019 Pali Roh?r <[email protected]>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index f747bf72edbe..1c42f544096d 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -11,8 +11,8 @@
> * This code is based on version 2.00 of the UDF specification,
> * and revision 3 of the ECMA 167 standard [equivalent to ISO 13346].
> * http://www.osta.org/
> - * http://www.ecma.ch/
> - * http://www.iso.org/
> + * https://www.ecma.ch/
> + * https://www.iso.org/
> *
> * COPYRIGHT
> * This file is distributed under the terms of the GNU General Public
> --
> 2.27.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR