2020-07-15 00:40:33

by Qiwu Huang

Subject: [PATCH v3 5/5] power: supply: core: supply battery soc with decimal form

From: Qiwu Huang <[email protected]>

Broadcast battery soc with decimal form.
soc_decimal is the decimal part of battery soc.
soc_decimal_rate is update frequency of decimal
part of battery soc.
We want to report such as 0.01 to 99.99% to
user space to improve user experience
when do very quick charging.

Signed-off-by: Qiwu Huang <[email protected]>
---
Documentation/ABI/testing/sysfs-class-power | 25 +++++++++++++++++++++
drivers/power/supply/power_supply_sysfs.c | 2 ++
include/linux/power_supply.h | 2 ++
3 files changed, 29 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index 54647d6995d3..5e0bba3e1930 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -349,6 +349,31 @@ Description:
Access: Read
Valid values: Represented in microvolts

+What: /sys/class/power_supply/<supply_name>/soc_decimal,
+Date: Jul 2020
+Contact: [email protected]
+Description:
+ Broadcast battery soc with decimal form.Battery soc(0 - 100 percent)
+ is fine grain representation of battery capacity.
+ soc_decimal is the start decimal part of battery soc.
+ For example, soc_decimal value is 30 for 80.30%.
+
+ Access: Read
+ Valid values: 0 - 99
+
+What: /sys/class/power_supply/<supply_name>/soc_decimal_rate,
+Date: Jul 2020
+Contact: [email protected]
+Description:
+ Broadcast battery soc with decimal form.Battery soc(0 - 100 percent)
+ is fine grain representation of battery capacity.
+ soc_decimal_rate is update rate for decimal part of battery soc.
+ The value is depend on charging power. Soc decimal change faster
+ with larger charging power.
+
+ Access: Read
+ Valid values: 1 - 100
+
===== USB Properties =====

What: /sys/class/power_supply/<supply_name>/current_avg
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index 81916b6b6ccf..a837addb4f21 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -210,6 +210,8 @@ static struct power_supply_attr power_supply_attrs[] = {
POWER_SUPPLY_ATTR(TX_ADAPTER),
POWER_SUPPLY_ATTR(SIGNAL_STRENGTH),
POWER_SUPPLY_ATTR(REVERSE_CHG_MODE),
+ POWER_SUPPLY_ATTR(SOC_DECIMAL),
+ POWER_SUPPLY_ATTR(SOC_DECIMAL_RATE),
};

static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index a87ae1fff8d1..71e7c8010bde 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -171,6 +171,8 @@ enum power_supply_property {
POWER_SUPPLY_PROP_TX_ADAPTER,
POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
POWER_SUPPLY_PROP_REVERSE_CHG_MODE,
+ POWER_SUPPLY_PROP_SOC_DECIMAL,
+ POWER_SUPPLY_PROP_SOC_DECIMAL_RATE,
};

enum power_supply_type {
--
2.27.0

2020-07-15 07:12:36

by Greg Kroah-Hartman

Subject: Re: [PATCH v3 5/5] power: supply: core: supply battery soc with decimal form

On Wed, Jul 15, 2020 at 08:35:23AM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <[email protected]>
>
> Broadcast battery soc with decimal form.

What does "soc" mean?


> soc_decimal is the decimal part of battery soc.
> soc_decimal_rate is update frequency of decimal
> part of battery soc.
> We want to report such as 0.01 to 99.99% to
> user space to improve user experience
> when do very quick charging.

You can wrap your lines a bit longer, 72 columns is usually the normal
spot :)

thanks,

greg k-h