2020-07-15 07:44:48

by Bhanu Prakash Maiya

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

From: Bhanu Prakash Maiya <[email protected]>

Add DT compatible string in
Documentation/devicetree/bindings/mfd/cros_ec.txt

Series-to: LKML <[email protected]>
Series-cc: Raul E Rangel <[email protected]>, Furquan Shaikh <[email protected]>, Duncan Laurie <[email protected]>, Eric Peers <[email protected]>, Benson Leung <[email protected]>, Enric Balletbo i Serra <[email protected]>, Guenter Roeck <[email protected]>, [email protected], Lee Jones <[email protected]>, Rob Herring <[email protected]>, [email protected]

Signed-off-by: Bhanu Prakash Maiya <[email protected]>
Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822
---
Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
index 4860eabd0f729..ec8c5d7ecc266 100644
--- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
+++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
@@ -3,7 +3,7 @@ ChromeOS Embedded Controller
Google's ChromeOS EC is a Cortex-M device which talks to the AP and
implements various function such as keyboard and battery charging.

-The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
+The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the
compatible string used depends on the interface. Each connection method has
its own driver which connects to the top level interface-agnostic EC driver.
Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
@@ -17,6 +17,10 @@ Required properties (SPI):
- compatible: "google,cros-ec-spi"
- reg: SPI chip select

+Required properties (UART):
+- compatible: "google,cros-ec-uart"
+- reg: UART baudrate, flowcontrol
+
Required properties (RPMSG):
- compatible: "google,cros-ec-rpmsg"

@@ -72,5 +76,6 @@ spi@131b0000 {
};
};

-
Example for LPC is not supplied as it is not yet implemented.
+
+Example for UART is not supplied as it is not yet implemented.
--
2.26.2


2020-07-15 07:57:53

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

On Wed, Jul 15, 2020 at 12:41:31AM -0700, Bhanu Prakash Maiya wrote:
> From: Bhanu Prakash Maiya <[email protected]>
>
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
>
> Series-to: LKML <[email protected]>
> Series-cc: Raul E Rangel <[email protected]>, Furquan Shaikh <[email protected]>, Duncan Laurie <[email protected]>, Eric Peers <[email protected]>, Benson Leung <[email protected]>, Enric Balletbo i Serra <[email protected]>, Guenter Roeck <[email protected]>, [email protected], Lee Jones <[email protected]>, Rob Herring <[email protected]>, [email protected]

That looks a bit odd, don't you think?

> Signed-off-by: Bhanu Prakash Maiya <[email protected]>
> Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822

Again, checkpatch.pl is your friend.

thanks,

greg k-h