2020-07-16 19:19:14

by Suraj Upadhyay

[permalink] [raw]

Subject: [PATCH] net: decnet: af_decnet: Simplify goto loop.

---

Replace goto loop with while loop.

Signed-off-by: Suraj Upadhyay <[email protected]>
---
net/decnet/af_decnet.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
index 0a46ea3bddd5..7d7ae2dd69b8 100644
--- a/net/decnet/af_decnet.c
+++ b/net/decnet/af_decnet.c
@@ -2134,14 +2134,11 @@ static struct sock *dn_socket_get_next(struct seq_file *seq,
struct dn_iter_state *state = seq->private;

n = sk_next(n);
-try_again:
- if (n)
- goto out;
- if (++state->bucket >= DN_SK_HASH_SIZE)
- goto out;
- n = sk_head(&dn_sk_hash[state->bucket]);
- goto try_again;
-out:
+ while (!n) {
+ if (++state->bucket >= DN_SK_HASH_SIZE)
+ break;
+ n = sk_head(&dn_sk_hash[state->bucket]);
+ }
return n;
}

--
2.17.1

---

Attachments:

(No filename) (830.00 B)
signature.asc (849.00 B)
Download all attachments

2020-07-17 19:58:44

by David Miller

[permalink] [raw]

Subject: Re: [PATCH] net: decnet: af_decnet: Simplify goto loop.

---

From: Suraj Upadhyay <[email protected]>
Date: Fri, 17 Jul 2020 00:46:45 +0530

> Replace goto loop with while loop.
>
> Signed-off-by: Suraj Upadhyay <[email protected]>

Applied to net-next.