2020-07-17 15:24:40

by Al Cooper

Subject: [PATCH 7/7] usb: bdc: Use devm_clk_get_optional()

From: Florian Fainelli <[email protected]>

The BDC clock is optional and we may get an -EPROBE_DEFER error code
which would not be propagated correctly, fix this by using
devm_clk_get_optional().

Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index ac989adefe9d..5d8bd9129365 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -497,11 +497,9 @@ static int bdc_probe(struct platform_device *pdev)

dev_dbg(dev, "%s()\n", __func__);

- clk = devm_clk_get(dev, "sw_usbd");
- if (IS_ERR(clk)) {
- dev_info(dev, "Clock not found in Device Tree\n");
- clk = NULL;
- }
+ clk = devm_clk_get_optional(dev, "sw_usbd");
+ if (IS_ERR(clk))
+ return PTR_ERR(clk);

ret = clk_prepare_enable(clk);
if (ret) {
--
2.17.1

2020-07-17 17:00:36

by Florian Fainelli

Subject: Re: [PATCH 7/7] usb: bdc: Use devm_clk_get_optional()

On 7/17/2020 8:23 AM, Al Cooper wrote:
> From: Florian Fainelli <[email protected]>
>
> The BDC clock is optional and we may get an -EPROBE_DEFER error code
> which would not be propagated correctly, fix this by using
> devm_clk_get_optional().
>
> Signed-off-by: Florian Fainelli <[email protected]>

Since you are carrying this patch on my behalf your Signed-off-by should
also be present, if you don't mind, I would like my gmail.com address to
be used here for consistency with all submissions done throughout my
tenure at broadcom, thanks!
--
Florian