2020-07-18 15:53:30

by Suraj Upadhyay

[permalink] [raw]

Subject: [PATCH v2] staging: kpc2000: Replace depracated MSI API.

---

Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
And as a result modify how the returned value is handled.

Signed-off-by: Suraj Upadhyay <[email protected]>
---
Changes:
v2: Removed the undefined variable.
Reported by kernel-bot.

drivers/staging/kpc2000/kpc2000/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
index 358d7b2f4ad1..8339026ffb41 100644
--- a/drivers/staging/kpc2000/kpc2000/core.c
+++ b/drivers/staging/kpc2000/kpc2000/core.c
@@ -440,7 +440,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
dev_dbg(&pcard->pdev->dev,
"Using DMA mask %0llx\n", dma_get_mask(PCARD_TO_DEV(pcard)));

- err = pci_enable_msi(pcard->pdev);
+ err = pci_alloc_irq_vectors(pcard->pdev, 1, 1, PCI_IRQ_MSI);
if (err < 0)
goto err_release_dma;

--
2.17.1

---

Attachments:

(No filename) (919.00 B)
signature.asc (849.00 B)
Download all attachments

2020-07-19 04:34:26

by Suraj Upadhyay

[permalink] [raw]

Subject: Re: [PATCH v2] staging: kpc2000: Replace depracated MSI API.

---

On Sat, Jul 18, 2020 at 09:19:51PM +0530, Suraj Upadhyay wrote:
> Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
> And as a result modify how the returned value is handled.
>
> Signed-off-by: Suraj Upadhyay <[email protected]>
> ---
> Changes:
> v2: Removed the undefined variable.
> Reported by kernel-bot.
>
Don't merge it.
This patch is incomplete.
I have to replce pci_disable_msi too.
I hope this didn't cause any annoyances.

Thanks,

Suraj Upadhyay.

> drivers/staging/kpc2000/kpc2000/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c
> index 358d7b2f4ad1..8339026ffb41 100644
> --- a/drivers/staging/kpc2000/kpc2000/core.c
> +++ b/drivers/staging/kpc2000/kpc2000/core.c
> @@ -440,7 +440,7 @@ static int kp2000_pcie_probe(struct pci_dev *pdev,
> dev_dbg(&pcard->pdev->dev,
> "Using DMA mask %0llx\n", dma_get_mask(PCARD_TO_DEV(pcard)));
>
> - err = pci_enable_msi(pcard->pdev);
> + err = pci_alloc_irq_vectors(pcard->pdev, 1, 1, PCI_IRQ_MSI);
> if (err < 0)
> goto err_release_dma;
>
> --
> 2.17.1
>