2020-07-16 21:15:39

by Gustavo A. R. Silva

Subject: [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index a917a2df520e..d6e35cba3065 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1372,13 +1372,13 @@ static void byt_irq_unmask(struct irq_data *d)
switch (irqd_get_trigger_type(d)) {
case IRQ_TYPE_LEVEL_HIGH:
value |= BYT_TRIG_LVL;
- /* fall through */
+ fallthrough;
case IRQ_TYPE_EDGE_RISING:
value |= BYT_TRIG_POS;
break;
case IRQ_TYPE_LEVEL_LOW:
value |= BYT_TRIG_LVL;
- /* fall through */
+ fallthrough;
case IRQ_TYPE_EDGE_FALLING:
value |= BYT_TRIG_NEG;
break;
--
2.27.0

2020-07-20 10:43:05

by Andy Shevchenko

Subject: Re: [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword

On Thu, Jul 16, 2020 at 04:19:19PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Pushed to my review and testing queue, thanks!

>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index a917a2df520e..d6e35cba3065 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1372,13 +1372,13 @@ static void byt_irq_unmask(struct irq_data *d)
> switch (irqd_get_trigger_type(d)) {
> case IRQ_TYPE_LEVEL_HIGH:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_RISING:
> value |= BYT_TRIG_POS;
> break;
> case IRQ_TYPE_LEVEL_LOW:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_FALLING:
> value |= BYT_TRIG_NEG;
> break;
> --
> 2.27.0
>

--
With Best Regards,
Andy Shevchenko