2020-07-20 07:38:15

by Xiongfeng Wang

Subject: [PATCH] Input: psmouse: add a newline when printing 'proto' by sysfs

When I cat parameter 'proto' by sysfs, it displays as follows. It's
better to add a newline for easy reading.

root@syzkaller:~# cat /sys/module/psmouse/parameters/proto
autoroot@syzkaller:~#

Signed-off-by: Xiongfeng Wang <[email protected]>
---
drivers/input/mouse/psmouse-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 527ae0b9a191..0b4a3039f312 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -2042,7 +2042,7 @@ static int psmouse_get_maxproto(char *buffer, const struct kernel_param *kp)
{
int type = *((unsigned int *)kp->arg);

- return sprintf(buffer, "%s", psmouse_protocol_by_type(type)->name);
+ return sprintf(buffer, "%s\n", psmouse_protocol_by_type(type)->name);
}

static int __init psmouse_init(void)
--
2.20.1

2020-07-22 05:35:26

by Dmitry Torokhov

Subject: Re: [PATCH] Input: psmouse: add a newline when printing 'proto' by sysfs

On Mon, Jul 20, 2020 at 03:38:46PM +0800, Xiongfeng Wang wrote:
> When I cat parameter 'proto' by sysfs, it displays as follows. It's
> better to add a newline for easy reading.
>
> root@syzkaller:~# cat /sys/module/psmouse/parameters/proto
> autoroot@syzkaller:~#
>
> Signed-off-by: Xiongfeng Wang <[email protected]>

Applied, thank you.

--
Dmitry