2020-07-23 10:48:58

by Max Chou

Subject: [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier

From: Max Chou <[email protected]>

The original return is NOTIFY_STOP, but notifier_call_chain would stop
the future call for register_pm_notifier even registered on other Kernel
modules with the same priority which value is zero.

Signed-off-by: Max Chou <[email protected]>
---
net/bluetooth/hci_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 6509f785dd14..3ce06347216a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3513,7 +3513,7 @@ static int hci_suspend_notifier(struct notifier_block *nb, unsigned long action,
bt_dev_err(hdev, "Suspend notifier action (%lu) failed: %d",
action, ret);

- return NOTIFY_STOP;
+ return NOTIFY_DONE;
}

/* Alloc HCI device */
--
2.17.1

2020-07-28 07:16:07

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier

Hi Max,

> The original return is NOTIFY_STOP, but notifier_call_chain would stop
> the future call for register_pm_notifier even registered on other Kernel
> modules with the same priority which value is zero.
>
> Signed-off-by: Max Chou <[email protected]>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel