LinuxLists.cc - Re: [PATCH for v5.9] arm64: Replace HTTP links with HTTPS ones

2020-07-19 19:43:10

Subject: Re: [PATCH for v5.9] arm64: Replace HTTP links with HTTPS ones

On Sun, 19 Jul 2020 at 19:29, Alexander A. Klimov
<[email protected]> wrote:
>
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>

Please do not modify .S_shipped files or the .pl file that generates
them - they were taken from other projects, and should remain in sync
with their upstream counterparts.

> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely
> or at least not (just) HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> Documentation/arm64/arm-acpi.rst | 2 +-
> arch/arm64/crypto/sha256-core.S_shipped | 2 +-
> arch/arm64/crypto/sha512-armv8.pl | 2 +-
> arch/arm64/crypto/sha512-core.S_shipped | 2 +-
> arch/arm64/lib/copy_template.S | 2 +-
> arch/arm64/lib/memcmp.S | 2 +-
> arch/arm64/lib/memcpy.S | 2 +-
> arch/arm64/lib/memmove.S | 2 +-
> arch/arm64/lib/memset.S | 2 +-
> arch/arm64/lib/strcmp.S | 2 +-
> arch/arm64/lib/strlen.S | 2 +-
> arch/arm64/lib/strncmp.S | 2 +-
> arch/arm64/lib/strnlen.S | 2 +-
> 13 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/arm64/arm-acpi.rst b/Documentation/arm64/arm-acpi.rst
> index 872dbbc73d4a..8f675c38c244 100644
> --- a/Documentation/arm64/arm-acpi.rst
> +++ b/Documentation/arm64/arm-acpi.rst
> @@ -273,7 +273,7 @@ only use the _DSD Device Properties UUID [5]:
>
> - UUID: daffd814-6eba-4d8c-8a91-bc9bbf4aa301
>
> - - http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
> + - https://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
>
> The UEFI Forum provides a mechanism for registering device properties [4]
> so that they may be used across all operating systems supporting ACPI.
> diff --git a/arch/arm64/crypto/sha256-core.S_shipped b/arch/arm64/crypto/sha256-core.S_shipped
> index 7c7ce2e3bad6..dd4867742a2e 100644
> --- a/arch/arm64/crypto/sha256-core.S_shipped
> +++ b/arch/arm64/crypto/sha256-core.S_shipped
> @@ -19,7 +19,7 @@
> // Written by Andy Polyakov <[email protected]> for the OpenSSL
> // project. The module is, however, dual licensed under OpenSSL and
> // CRYPTOGAMS licenses depending on where you obtain it. For further
> -// details see http://www.openssl.org/~appro/cryptogams/.
> +// details see https://www.openssl.org/~appro/cryptogams/.
> // ====================================================================
> //
> // SHA256/512 for ARMv8.
> diff --git a/arch/arm64/crypto/sha512-armv8.pl b/arch/arm64/crypto/sha512-armv8.pl
> index 2d8655d5b1af..48c9da50b7ec 100644
> --- a/arch/arm64/crypto/sha512-armv8.pl
> +++ b/arch/arm64/crypto/sha512-armv8.pl
> @@ -20,7 +20,7 @@
> # Written by Andy Polyakov <[email protected]> for the OpenSSL
> # project. The module is, however, dual licensed under OpenSSL and
> # CRYPTOGAMS licenses depending on where you obtain it. For further
> -# details see http://www.openssl.org/~appro/cryptogams/.
> +# details see https://www.openssl.org/~appro/cryptogams/.
> # ====================================================================
> #
> # SHA256/512 for ARMv8.
> diff --git a/arch/arm64/crypto/sha512-core.S_shipped b/arch/arm64/crypto/sha512-core.S_shipped
> index e063a6106720..421cb9977d39 100644
> --- a/arch/arm64/crypto/sha512-core.S_shipped
> +++ b/arch/arm64/crypto/sha512-core.S_shipped
> @@ -19,7 +19,7 @@
> // Written by Andy Polyakov <[email protected]> for the OpenSSL
> // project. The module is, however, dual licensed under OpenSSL and
> // CRYPTOGAMS licenses depending on where you obtain it. For further
> -// details see http://www.openssl.org/~appro/cryptogams/.
> +// details see https://www.openssl.org/~appro/cryptogams/.
> // ====================================================================
> //
> // SHA256/512 for ARMv8.
> diff --git a/arch/arm64/lib/copy_template.S b/arch/arm64/lib/copy_template.S
> index 488df234c49a..fce1e070c13a 100644
> --- a/arch/arm64/lib/copy_template.S
> +++ b/arch/arm64/lib/copy_template.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/memcmp.S b/arch/arm64/lib/memcmp.S
> index c0671e793ea9..8b7c94917f98 100644
> --- a/arch/arm64/lib/memcmp.S
> +++ b/arch/arm64/lib/memcmp.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/memcpy.S b/arch/arm64/lib/memcpy.S
> index e0bf83d556f2..dc816480cebd 100644
> --- a/arch/arm64/lib/memcpy.S
> +++ b/arch/arm64/lib/memcpy.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/memmove.S b/arch/arm64/lib/memmove.S
> index 02cda2e33bde..3cd7ba7311e5 100644
> --- a/arch/arm64/lib/memmove.S
> +++ b/arch/arm64/lib/memmove.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/memset.S b/arch/arm64/lib/memset.S
> index 77c3c7ba0084..ff1e38b96d1c 100644
> --- a/arch/arm64/lib/memset.S
> +++ b/arch/arm64/lib/memset.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/strcmp.S b/arch/arm64/lib/strcmp.S
> index 4e79566726c8..9dab831b1558 100644
> --- a/arch/arm64/lib/strcmp.S
> +++ b/arch/arm64/lib/strcmp.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/strlen.S b/arch/arm64/lib/strlen.S
> index ee3ed882dd79..f981b639d549 100644
> --- a/arch/arm64/lib/strlen.S
> +++ b/arch/arm64/lib/strlen.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/strncmp.S b/arch/arm64/lib/strncmp.S
> index 2a7ee949ed47..0243547021b2 100644
> --- a/arch/arm64/lib/strncmp.S
> +++ b/arch/arm64/lib/strncmp.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> diff --git a/arch/arm64/lib/strnlen.S b/arch/arm64/lib/strnlen.S
> index b72913a99038..ffe5ba5a3387 100644
> --- a/arch/arm64/lib/strnlen.S
> +++ b/arch/arm64/lib/strnlen.S
> @@ -6,7 +6,7 @@
> * This code is based on glibc cortex strings work originally authored by Linaro
> * be found @
> *
> - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/
> * files/head:/src/aarch64/
> */
>
> --
> 2.27.0
>

2020-07-20 21:13:36

by Alexander A. Klimov

[permalink] [raw]

Subject: [PATCH v2] arm64: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Now better?

Documentation/arm64/arm-acpi.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/arm64/arm-acpi.rst b/Documentation/arm64/arm-acpi.rst
index 872dbbc73d4a..8f675c38c244 100644
--- a/Documentation/arm64/arm-acpi.rst
+++ b/Documentation/arm64/arm-acpi.rst
@@ -273,7 +273,7 @@ only use the _DSD Device Properties UUID [5]:

- UUID: daffd814-6eba-4d8c-8a91-bc9bbf4aa301

- - http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
+ - https://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf

The UEFI Forum provides a mechanism for registering device properties [4]
so that they may be used across all operating systems supporting ACPI.
--
2.27.0

2020-07-23 20:05:27

by Jonathan Corbet

[permalink] [raw]

Subject: Re: [PATCH v2] arm64: Replace HTTP links with HTTPS ones

On Mon, 20 Jul 2020 23:12:31 +0200
"Alexander A. Klimov" <[email protected]> wrote:

> Documentation/arm64/arm-acpi.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/arm64/arm-acpi.rst b/Documentation/arm64/arm-acpi.rst
> index 872dbbc73d4a..8f675c38c244 100644
> --- a/Documentation/arm64/arm-acpi.rst
> +++ b/Documentation/arm64/arm-acpi.rst
> @@ -273,7 +273,7 @@ only use the _DSD Device Properties UUID [5]:
>
> - UUID: daffd814-6eba-4d8c-8a91-bc9bbf4aa301
>
> - - http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
> + - https://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf
>
> The UEFI Forum provides a mechanism for registering device properties [4]
> so that they may be used across all operating systems supporting ACPI.

Applied, thanks.

jon