2020-07-23 16:32:47

by Muhammad Usama Anjum

Subject: [PATCH v2] staging: octeon: Add the license identifier

This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag

Add a the SPDX-License-Identifier tag on line 1

Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
Other files in this folder have GPL-2.0 license. So this file should
have the same license which was missing before and checkpatch.pl was
giving the warning.

drivers/staging/octeon/octeon-stubs.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index d06743504f2b..3f8e5713b8a8 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
#define CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE 512

#ifndef XKPHYS_TO_PHYS
--
2.17.1

2020-07-23 17:37:11

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] staging: octeon: Add the license identifier

On Thu, Jul 23, 2020 at 09:31:50PM +0500, Muhammad Usama Anjum wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Missing or malformed SPDX-License-Identifier tag
>
> Add a the SPDX-License-Identifier tag on line 1
>
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> Other files in this folder have GPL-2.0 license. So this file should
> have the same license which was missing before and checkpatch.pl was
> giving the warning.

Why is this information not up in the changelog area?

And what changeds from v1? ALways put that below the --- line.

v3?

thanks,

greg k-h