2020-07-25 10:33:41

by Anant Thazhemadam

Subject: [PATCH] Fix one coding style issue

The coding style issue that raised an error (upon checking against
checkpatch.pl) has been fixed.
Exactly one coding style issue has been fixed; as required by Task 10
of the Eudyptula Challenge.

Signed-off-by: Anant Thazhemadam <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index 21f6652dd69f..dc22ee9c24ad 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
res = _FAIL;
}
} else {
- RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+ RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
+ ("%s: stainfo==NULL!!!\n", __func__)
+ );
res = _FAIL;
}
}
--
2.25.1

2020-07-25 11:07:05

by Greg Kroah-Hartman

Subject: Re: [PATCH] Fix one coding style issue

On Sat, Jul 25, 2020 at 04:00:03PM +0530, Anant Thazhemadam wrote:
> The coding style issue that raised an error (upon checking against
> checkpatch.pl) has been fixed.

You are not saying what issue was fixed.

Also, your subject line needs to be fixed, please see the link provided
by the bot previously for what to do.

> Exactly one coding style issue has been fixed; as required by Task 10
> of the Eudyptula Challenge.

We don't care why you are doing this work, no need to put that in the
changelog.

>
> Signed-off-by: Anant Thazhemadam <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index 21f6652dd69f..dc22ee9c24ad 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -718,7 +718,9 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
> res = _FAIL;
> }
> } else {
> - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> + RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> + ("%s: stainfo==NULL!!!\n", __func__)
> + );

Very odd line breaks, this now looks worse than before :(

thanks,

greg k-h