2020-07-26 19:25:21

by Julia Lawall

Subject: [PATCH] docs: filesystems: vfs: correct flag name

There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
remap callers that can handle short operations") that introduces this
text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
in the documentation accordingly.

Signed-off-by: Julia Lawall <[email protected]>

---
Documentation/filesystems/vfs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
index da4b735..d08357d 100644
--- a/Documentation/filesystems/vfs.rst
+++ b/Documentation/filesystems/vfs.rst
@@ -1116,7 +1116,7 @@ otherwise noted.
before any bytes were remapped. The remap_flags parameter
accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
implementation must only remap if the requested file ranges have
- identical contents. If REMAP_CAN_SHORTEN is set, the caller is
+ identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
ok with the implementation shortening the request length to
satisfy alignment or EOF requirements (or any other reason).

2020-07-27 01:52:46

by Darrick J. Wong

Subject: Re: [PATCH] docs: filesystems: vfs: correct flag name

On Sun, Jul 26, 2020 at 08:43:40PM +0200, Julia Lawall wrote:
> There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
> remap callers that can handle short operations") that introduces this
> text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall <[email protected]>

D'oh. Good catch!
Reviewed-by: Darrick J. Wong <[email protected]>

--D

>
> ---
> Documentation/filesystems/vfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index da4b735..d08357d 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -1116,7 +1116,7 @@ otherwise noted.
> before any bytes were remapped. The remap_flags parameter
> accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
> implementation must only remap if the requested file ranges have
> - identical contents. If REMAP_CAN_SHORTEN is set, the caller is
> + identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is
> ok with the implementation shortening the request length to
> satisfy alignment or EOF requirements (or any other reason).
>
>

2020-07-27 22:23:41

by Jonathan Corbet

Subject: Re: [PATCH] docs: filesystems: vfs: correct flag name

On Sun, 26 Jul 2020 20:43:40 +0200
Julia Lawall <[email protected]> wrote:

> There is no flag REMAP_CAN_SHORTEN. Commit eca3654e3cc7 ("vfs: enable
> remap callers that can handle short operations") that introduces this
> text also introduces the flag REMAP_FILE_CAN_SHORTEN. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> Documentation/filesystems/vfs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/vfs.rst b/Documentation/filesystems/vfs.rst
> index da4b735..d08357d 100644
> --- a/Documentation/filesystems/vfs.rst
> +++ b/Documentation/filesystems/vfs.rst
> @@ -1116,7 +1116,7 @@ otherwise noted.
> before any bytes were remapped. The remap_flags parameter
> accepts REMAP_FILE_* flags. If REMAP_FILE_DEDUP is set then the
> implementation must only remap if the requested file ranges have
> - identical contents. If REMAP_CAN_SHORTEN is set, the caller is
> + identical contents. If REMAP_FILE_CAN_SHORTEN is set, the caller is

Applied, thanks.

jon