2020-07-27 02:53:24

by Xu Wang

Subject: [PATCH] usb: endpoint : remove needless check before usb_free_coherent()

usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: Xu Wang <[email protected]>
---
sound/usb/endpoint.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index 88760268fb55..3a2b2a309a71 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -615,9 +615,8 @@ static void release_urbs(struct snd_usb_endpoint *ep, int force)
for (i = 0; i < ep->nurbs; i++)
release_urb_ctx(&ep->urb[i]);

- if (ep->syncbuf)
- usb_free_coherent(ep->chip->dev, SYNC_URBS * 4,
- ep->syncbuf, ep->sync_dma);
+ usb_free_coherent(ep->chip->dev, SYNC_URBS * 4,
+ ep->syncbuf, ep->sync_dma);

ep->syncbuf = NULL;
ep->nurbs = 0;
--
2.17.1

2020-07-27 18:54:06

by Takashi Iwai

Subject: Re: [PATCH] usb: endpoint : remove needless check before usb_free_coherent()

On Mon, 27 Jul 2020 04:52:08 +0200,
Xu Wang wrote:
>
> usb_free_coherent() is safe with NULL addr and this check is
> not required.
>
> Signed-off-by: Xu Wang <[email protected]>

Thanks, applied.


Takashi