2020-07-29 09:50:02

by Jisheng Zhang

Subject: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

mvneta has switched to phylink, so the comment should look
like "We may have called phylink_speed_down before".

Signed-off-by: Jisheng Zhang <[email protected]>
---
Since v1:
- drop patch2 which tries to avoid link flapping when changing mtu
I need more time on the change mtu refactoring.

drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 2c9277e73cef..c9b6b0f85bb0 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)

phylink_start(pp->phylink);

- /* We may have called phy_speed_down before */
+ /* We may have called phylink_speed_down before */
phylink_speed_up(pp->phylink);

netif_tx_start_all_queues(pp->dev);
--
2.28.0.rc0

2020-07-29 10:10:51

by Russell King (Oracle)

Subject: Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

On Wed, Jul 29, 2020 at 05:49:09PM +0800, Jisheng Zhang wrote:
> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Reviewed-by: Russell King <[email protected]>

> ---
> Since v1:
> - drop patch2 which tries to avoid link flapping when changing mtu
> I need more time on the change mtu refactoring.
>
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 2c9277e73cef..c9b6b0f85bb0 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3637,7 +3637,7 @@ static void mvneta_start_dev(struct mvneta_port *pp)
>
> phylink_start(pp->phylink);
>
> - /* We may have called phy_speed_down before */
> + /* We may have called phylink_speed_down before */
> phylink_speed_up(pp->phylink);
>
> netif_tx_start_all_queues(pp->dev);
> --
> 2.28.0.rc0
>
>

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2020-07-29 19:19:13

by David Miller

Subject: Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

From: Jisheng Zhang <[email protected]>
Date: Wed, 29 Jul 2020 17:49:09 +0800

> mvneta has switched to phylink, so the comment should look
> like "We may have called phylink_speed_down before".
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> Since v1:
> - drop patch2 which tries to avoid link flapping when changing mtu
> I need more time on the change mtu refactoring.

Applied, thank you.