The tablet has a vibrator motor. This patch series exposes it via
input subsystem (EV_FF).
I'd like to ask input maintainers to take the patches 1 and 2.
Patches 3 and 4 should go via the sunxi tree.
The change to the vibrator driver is meant to enable toggling the
vibrator motor just via a power supply itself. There's not additional
gpio driven switch on this tablet between the power supply for the
motor and the motor.
Please take a look.
Changes in v5:
- Fix probe without a power supply (Dmitry)
Changes in v4:
- Added DT reviewed-by tag
- Fixed motor typo
Changes in v3:
- Changed dt-binding to require at least one of enable/supply, dropped ack
- Changed driver to bail out if neither supply nor gpio is given
Changes in v2:
- Added DT ack tag
- Add more information to the commit log (re use of LDO for the power)
thank you and regards,
Ondrej Jirman
Ondrej Jirman (4):
dt-bindings: input: gpio-vibrator: Don't require enable-gpios
input: gpio-vibra: Allow to use vcc-supply alone to control the
vibrator
ARM: dts: sun8i-a83t-tbs-a711: Add support for the vibrator motor
ARM: dts: sun8i-a83t-tbs-a711: Increase voltage on the vibrator
.../bindings/input/gpio-vibrator.yaml | 7 ++++++-
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 9 +++++++--
drivers/input/misc/gpio-vibra.c | 18 +++++++++++++-----
3 files changed, 26 insertions(+), 8 deletions(-)
--
2.27.0
It is possible to turn the motor on/off just by enabling/disabling
the vcc-supply. Change the binding to require either enable-gpios
or vcc-supply or both.
Signed-off-by: Ondrej Jirman <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
index 2384465eaa19..082ac06471db 100644
--- a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
@@ -24,7 +24,12 @@ properties:
required:
- compatible
- - enable-gpios
+
+anyOf:
+ - required:
+ - enable-gpios
+ - required:
+ - vcc-supply
additionalProperties: false
--
2.27.0