2020-07-31 08:54:41

by Wen Pu

[permalink] [raw]

Subject: [PATCH] i2c: designware: Add device HID for Hygon I2C controller

---

Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
was registered in http://www.uefi.org/acpi_id_list, and the I2C
controller on Hygon paltform will use the HID.

Signed-off-by: Pu Wen <[email protected]>
---
drivers/acpi/acpi_apd.c | 1 +
drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index ba2612e9a0eb..f24f6d3f1fa5 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
{ "AMDI0020", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
{ "AMD0040", APD_ADDR(st_misc_desc)},
+ { "HYGO0010", APD_ADDR(wt_i2c_desc) },
#endif
#ifdef CONFIG_ARM64
{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index a71bc58fc03c..0dfeb2d11603 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
{ "HISI02A1", 0 },
{ "HISI02A2", 0 },
{ "HISI02A3", 0 },
+ { "HYGO0010", ACCESS_INTR_MASK },
{ }
};
MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
--
2.23.0

2020-07-31 09:29:30

by Andy Shevchenko

[permalink] [raw]

Subject: Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller

---

On Fri, Jul 31, 2020 at 04:48:45PM +0800, Pu Wen wrote:
> Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
> was registered in http://www.uefi.org/acpi_id_list, and the I2C
> controller on Hygon paltform will use the HID.

Acked-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Pu Wen <[email protected]>
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ba2612e9a0eb..f24f6d3f1fa5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(st_misc_desc)},
> + { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> #endif
> #ifdef CONFIG_ARM64
> { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index a71bc58fc03c..0dfeb2d11603 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
> { "HISI02A1", 0 },
> { "HISI02A2", 0 },
> { "HISI02A3", 0 },
> + { "HYGO0010", ACCESS_INTR_MASK },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> --
> 2.23.0
>

--
With Best Regards,
Andy Shevchenko

2020-07-31 13:50:39

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller

---

On Fri, Jul 31, 2020 at 04:48:45PM +0800, Pu Wen wrote:
> Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
> was registered in http://www.uefi.org/acpi_id_list, and the I2C
> controller on Hygon paltform will use the HID.
>
> Signed-off-by: Pu Wen <[email protected]>

I can take this via I2C, but I'd need an ack from Rafael or Len.

Or it can go via ACPI, fine with me

Acked-by: Wolfram Sang <[email protected]>

> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ba2612e9a0eb..f24f6d3f1fa5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
> { "AMDI0020", APD_ADDR(cz_uart_desc) },
> { "AMD0030", },
> { "AMD0040", APD_ADDR(st_misc_desc)},
> + { "HYGO0010", APD_ADDR(wt_i2c_desc) },
> #endif
> #ifdef CONFIG_ARM64
> { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index a71bc58fc03c..0dfeb2d11603 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
> { "HISI02A1", 0 },
> { "HISI02A2", 0 },
> { "HISI02A3", 0 },
> + { "HYGO0010", ACCESS_INTR_MASK },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> --
> 2.23.0
>

---

Attachments:

(No filename) (1.59 kB)
signature.asc (849.00 B)
Download all attachments