2020-08-02 11:18:25

by Tianjia Zhang

Subject: [PATCH] scsi: qla2xxx: Remove redundant variable initialization

The initialization value of `rc` is wrong. It is unnecessary to
initialize `rc` variables, so remove its initialization operation.

Fixes: 84905dfe78d28 ("scsi: qla2xxx: Fix TMF and Multi-Queue config")
Cc: Quinn Tran <[email protected]>
Signed-off-by: Tianjia Zhang <[email protected]>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index fbb80a043b4f..c2c0e6049da4 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -2025,7 +2025,7 @@ static void qlt_do_tmr_work(struct work_struct *work)
struct qla_tgt_mgmt_cmd *mcmd =
container_of(work, struct qla_tgt_mgmt_cmd, work);
struct qla_hw_data *ha = mcmd->vha->hw;
- int rc = EIO;
+ int rc;
uint32_t tag;
unsigned long flags;

--
2.26.2

2020-08-31 17:42:53

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: Remove redundant variable initialization

On Sun, 2 Aug 2020 19:15:27 +0800, Tianjia Zhang wrote:

> The initialization value of `rc` is wrong. It is unnecessary to
> initialize `rc` variables, so remove its initialization operation.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove redundant variable initialization
https://git.kernel.org/mkp/scsi/c/8905cbdae986

--
Martin K. Petersen Oracle Linux Engineering