2020-08-02 11:16:13

by Tianjia Zhang

Subject: [PATCH] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()

On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: f40e74ffa3de4 ("csiostor:firmware upgrade fix")
Cc: Praveen Madhavan <[email protected]>
Signed-off-by: Tianjia Zhang <[email protected]>
---
drivers/scsi/csiostor/csio_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c
index 950f9cdf0577..5d0f42031d12 100644
--- a/drivers/scsi/csiostor/csio_hw.c
+++ b/drivers/scsi/csiostor/csio_hw.c
@@ -2384,7 +2384,7 @@ static int csio_hw_prep_fw(struct csio_hw *hw, struct fw_info *fw_info,
FW_HDR_FW_VER_MICRO_G(c), FW_HDR_FW_VER_BUILD_G(c),
FW_HDR_FW_VER_MAJOR_G(k), FW_HDR_FW_VER_MINOR_G(k),
FW_HDR_FW_VER_MICRO_G(k), FW_HDR_FW_VER_BUILD_G(k));
- ret = EINVAL;
+ ret = -EINVAL;
goto bye;
}

--
2.26.2

2020-08-31 17:43:08

by Martin K. Petersen

Subject: Re: [PATCH] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()

On Sun, 2 Aug 2020 19:15:31 +0800, Tianjia Zhang wrote:

> On an error exit path, a negative error code should be returned
> instead of a positive return value.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()
https://git.kernel.org/mkp/scsi/c/44f4daf8678a

--
Martin K. Petersen Oracle Linux Engineering