2020-08-02 11:19:49

by Tianjia Zhang

Subject: [PATCH] net: ethernet: aquantia: Fix wrong return value

In function hw_atl_a0_hw_multicast_list_set(), when an invalid
request is encountered, a negative error code should be returned.

Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
Cc: David VomLehn <[email protected]>
Signed-off-by: Tianjia Zhang <[email protected]>
---
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
index a312864969af..6640fd35b29b 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c
@@ -782,7 +782,7 @@ static int hw_atl_a0_hw_multicast_list_set(struct aq_hw_s *self,
int err = 0;

if (count > (HW_ATL_A0_MAC_MAX - HW_ATL_A0_MAC_MIN)) {
- err = EBADRQC;
+ err = -EBADRQC;
goto err_exit;
}
for (self->aq_nic_cfg->mc_list_count = 0U;
--
2.26.2

2020-08-03 22:59:20

by David Miller

Subject: Re: [PATCH] net: ethernet: aquantia: Fix wrong return value

From: Tianjia Zhang <[email protected]>
Date: Sun, 2 Aug 2020 19:15:37 +0800

> In function hw_atl_a0_hw_multicast_list_set(), when an invalid
> request is encountered, a negative error code should be returned.
>
> Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
> Cc: David VomLehn <[email protected]>
> Signed-off-by: Tianjia Zhang <[email protected]>

Applied, thank you!