2020-08-03 07:17:17

by Crystal Guo

[permalink] [raw]
Subject: [v4,0/5] watchdog: mt8192: add wdt support

v4 changes:
revise commit messages.

v3 changes:
https://patchwork.kernel.org/patch/11692731/
https://patchwork.kernel.org/patch/11692767/
https://patchwork.kernel.org/patch/11692729/
https://patchwork.kernel.org/patch/11692771/
https://patchwork.kernel.org/patch/11692733/

Crystal Guo (5):
dt-binding: mediatek: watchdog: fix the description of compatible
arm64: dts: mt8183: update watchdog device node
dt-binding: mediatek: mt8192: update mtk-wdt document
dt-binding: mt8192: add toprgu reset-controller head file
watchdog: mt8192: add wdt support

.../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-
drivers/watchdog/mtk_wdt.c | 6 ++++
.../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
4 files changed, 40 insertions(+), 4 deletions(-)
create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h



2020-08-03 07:17:37

by Crystal Guo

[permalink] [raw]
Subject: [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible

The watchdog driver for MT2712 and MT8183 relies on DT data, so
the fallback compatible MT6589 won't work.

Signed-off-by: Crystal Guo <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 4dd36bd3f1ad..45eedc2c3141 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -4,13 +4,13 @@ Required properties:

- compatible should contain:
"mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
+ "mediatek,mt2712-wdt": for MT2712
"mediatek,mt6589-wdt": for MT6589
"mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
"mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
"mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
"mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
+ "mediatek,mt8183-wdt": for MT8183
"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516

- reg : Specifies base physical address and size of the registers.
--
2.18.0

2020-09-11 03:29:38

by Nicolas Boichat

[permalink] [raw]
Subject: Re: [v4,0/5] watchdog: mt8192: add wdt support

Matthias, Guenter,

These patches have all been reviewed (apart from fairly trivial 2/5),
which maintainer should be picking those up?

Thanks!

On Mon, Aug 3, 2020 at 3:15 PM Crystal Guo <[email protected]> wrote:
>
> v4 changes:
> revise commit messages.
>
> v3 changes:
> https://patchwork.kernel.org/patch/11692731/
> https://patchwork.kernel.org/patch/11692767/
> https://patchwork.kernel.org/patch/11692729/
> https://patchwork.kernel.org/patch/11692771/
> https://patchwork.kernel.org/patch/11692733/
>
> Crystal Guo (5):
> dt-binding: mediatek: watchdog: fix the description of compatible
> arm64: dts: mt8183: update watchdog device node
> dt-binding: mediatek: mt8192: update mtk-wdt document
> dt-binding: mt8192: add toprgu reset-controller head file
> watchdog: mt8192: add wdt support
>
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-
> drivers/watchdog/mtk_wdt.c | 6 ++++
> .../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
> 4 files changed, 40 insertions(+), 4 deletions(-)
> create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
>
>

2020-09-14 15:15:56

by Guenter Roeck

[permalink] [raw]
Subject: Re: [v4,1/5] dt-binding: mediatek: watchdog: fix the description of compatible

On 8/3/20 12:14 AM, Crystal Guo wrote:
> The watchdog driver for MT2712 and MT8183 relies on DT data, so
> the fallback compatible MT6589 won't work.
>
> Signed-off-by: Crystal Guo <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index 4dd36bd3f1ad..45eedc2c3141 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -4,13 +4,13 @@ Required properties:
>
> - compatible should contain:
> "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt", "mediatek,mt6589-wdt": for MT2712
> + "mediatek,mt2712-wdt": for MT2712
> "mediatek,mt6589-wdt": for MT6589
> "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
> + "mediatek,mt8183-wdt": for MT8183
> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>
> - reg : Specifies base physical address and size of the registers.
>

2020-09-14 15:28:46

by Guenter Roeck

[permalink] [raw]
Subject: Re: [v4,0/5] watchdog: mt8192: add wdt support

On 9/10/20 8:26 PM, Nicolas Boichat wrote:
> Matthias, Guenter,
>
> These patches have all been reviewed (apart from fairly trivial 2/5),
> which maintainer should be picking those up?
>

I don't see an Acked-by or Reviewed-by from a DT maintainer.
We'll have to wait for feedback from Rob.

Thanks,
Guenter

> Thanks!
>
> On Mon, Aug 3, 2020 at 3:15 PM Crystal Guo <[email protected]> wrote:
>>
>> v4 changes:
>> revise commit messages.
>>
>> v3 changes:
>> https://patchwork.kernel.org/patch/11692731/
>> https://patchwork.kernel.org/patch/11692767/
>> https://patchwork.kernel.org/patch/11692729/
>> https://patchwork.kernel.org/patch/11692771/
>> https://patchwork.kernel.org/patch/11692733/
>>
>> Crystal Guo (5):
>> dt-binding: mediatek: watchdog: fix the description of compatible
>> arm64: dts: mt8183: update watchdog device node
>> dt-binding: mediatek: mt8192: update mtk-wdt document
>> dt-binding: mt8192: add toprgu reset-controller head file
>> watchdog: mt8192: add wdt support
>>
>> .../devicetree/bindings/watchdog/mtk-wdt.txt | 5 ++--
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-
>> drivers/watchdog/mtk_wdt.c | 6 ++++
>> .../reset-controller/mt8192-resets.h | 30 +++++++++++++++++++
>> 4 files changed, 40 insertions(+), 4 deletions(-)
>> create mode 100644 include/dt-bindings/reset-controller/mt8192-resets.h
>>
>>