2020-08-05 21:54:30

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

Hi Stephen,

On Wed, Aug 05, 2020 at 08:31:49PM +0200, Stephen Kitt wrote:
> All the drivers have long since been upgraded, and all the important
> information here is also included in the "Implementing I2C device
> drivers" guide.
>
> Signed-off-by: Stephen Kitt <[email protected]>

True! Thanks.

But I can't apply the patch?

> base-commit: 2324d50d051ec0f14a548e78554fb02513d6dcef

Maybe because I don't have the commit in my tree? Can you rebase on top
of 5.8?

And please also remove the reference in Documentation/i2c/index.rst

Kind regards,

Wolfram


Attachments:
(No filename) (585.00 B)
signature.asc (849.00 B)
Download all attachments

2020-08-06 07:10:53

by Stephen Kitt

[permalink] [raw]
Subject: Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

Hi Wolfram,

On Wed, 5 Aug 2020 23:53:51 +0200, Wolfram Sang <[email protected]> wrote:
> On Wed, Aug 05, 2020 at 08:31:49PM +0200, Stephen Kitt wrote:
> > All the drivers have long since been upgraded, and all the important
> > information here is also included in the "Implementing I2C device
> > drivers" guide.
> >
> > Signed-off-by: Stephen Kitt <[email protected]>
>
> True! Thanks.
>
> But I can't apply the patch?
>
> > base-commit: 2324d50d051ec0f14a548e78554fb02513d6dcef
>
> Maybe because I don't have the commit in my tree? Can you rebase on top
> of 5.8?

Ah, yes, the commit is on top of Linus’ current master, following the merge
of docs-5.9 from Jon’s tree. In 5.8 the file is a .txt file, but Mauro
converted it to .rst for 5.9, and this patch removes the latter file (to
avoid a merge conflict later on...). If you prefer, I can submit it to the
docs tree instead!

> And please also remove the reference in Documentation/i2c/index.rst

Oops, yes, I’ll do that in v2 once we decide where it should go.

Regards,

Stephen


Attachments:
(No filename) (849.00 B)
OpenPGP digital signature

2020-08-06 08:35:27

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide


> > Maybe because I don't have the commit in my tree? Can you rebase on top
> > of 5.8?
>
> Ah, yes, the commit is on top of Linus’ current master, following the merge
> of docs-5.9 from Jon’s tree. In 5.8 the file is a .txt file, but Mauro
> converted it to .rst for 5.9, and this patch removes the latter file (to
> avoid a merge conflict later on...). If you prefer, I can submit it to the
> docs tree instead!

I see. Thanks for the heads up!

> > And please also remove the reference in Documentation/i2c/index.rst
>
> Oops, yes, I’ll do that in v2 once we decide where it should go.

I am fine with either it going via the doc-tree or you sending me v2
again after 5.9-rc1. For the first case:

Acked-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (772.00 B)
signature.asc (849.00 B)
Download all attachments

2020-08-06 22:44:16

by Stephen Kitt

[permalink] [raw]
Subject: Re: [PATCH] docs: remove the 2.6 "Upgrading I2C Drivers" guide

Hi Jon,

You’ll see v2 of this patch show up soon, see the context below — this is a
patch on top of Mauro’s conversion of the i2c docs to .rst.

Regards,

Stephen


On Thu, 6 Aug 2020 10:33:56 +0200, Wolfram Sang <[email protected]> wrote:

> > > Maybe because I don't have the commit in my tree? Can you rebase on top
> > > of 5.8?
> >
> > Ah, yes, the commit is on top of Linus’ current master, following the
> > merge of docs-5.9 from Jon’s tree. In 5.8 the file is a .txt file, but
> > Mauro converted it to .rst for 5.9, and this patch removes the latter
> > file (to avoid a merge conflict later on...). If you prefer, I can submit
> > it to the docs tree instead!
>
> I see. Thanks for the heads up!
>
> > > And please also remove the reference in Documentation/i2c/index.rst
> >
> > Oops, yes, I’ll do that in v2 once we decide where it should go.
>
> I am fine with either it going via the doc-tree or you sending me v2
> again after 5.9-rc1. For the first case:
>
> Acked-by: Wolfram Sang <[email protected]>
>


Attachments:
(No filename) (849.00 B)
OpenPGP digital signature