2020-08-07 09:15:29

by Wei Yang

Subject: [PATCH 07/10] mm/hugetlb: a page from buddy is not on any list

The page allocated from buddy is not on any list, so just use list_add()
is enough.

Signed-off-by: Wei Yang <[email protected]>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index fb09e5a83c39..b8e844911b5a 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2430,7 +2430,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,
h->resv_huge_pages--;
}
spin_lock(&hugetlb_lock);
- list_move(&page->lru, &h->hugepage_activelist);
+ list_add(&page->lru, &h->hugepage_activelist);
/* Fall through */
}
hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, page);
--
2.20.1 (Apple Git-117)

2020-08-07 13:08:03

by Baoquan He

Subject: Re: [PATCH 07/10] mm/hugetlb: a page from buddy is not on any list

On 08/07/20 at 05:12pm, Wei Yang wrote:
> The page allocated from buddy is not on any list, so just use list_add()
> is enough.
>
> Signed-off-by: Wei Yang <[email protected]>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index fb09e5a83c39..b8e844911b5a 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2430,7 +2430,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,
> h->resv_huge_pages--;
> }
> spin_lock(&hugetlb_lock);
> - list_move(&page->lru, &h->hugepage_activelist);
> + list_add(&page->lru, &h->hugepage_activelist);

Looks good to me.

Reviewed-by: Baoquan He <[email protected]>

> /* Fall through */
> }
> hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, page);
> --
> 2.20.1 (Apple Git-117)
>
>

2020-08-10 22:29:48

by Mike Kravetz

Subject: Re: [PATCH 07/10] mm/hugetlb: a page from buddy is not on any list

On 8/7/20 2:12 AM, Wei Yang wrote:
> The page allocated from buddy is not on any list, so just use list_add()
> is enough.
>
> Signed-off-by: Wei Yang <[email protected]>

Thanks!

Reviewed-by: Mike Kravetz <[email protected]>

--
Mike Kravetz