2020-08-08 09:21:06

by Miaohe Lin

Subject: [PATCH] erofs: Convert to use the fallthrough macro

From: Miaohe Lin <[email protected]>

Convert the uses of fallthrough comments to fallthrough macro.

Signed-off-by: Hongxiang Lou <[email protected]>
Signed-off-by: Miaohe Lin <[email protected]>
---
fs/erofs/zmap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c
index 7d40d78ea864..ae325541884e 100644
--- a/fs/erofs/zmap.c
+++ b/fs/erofs/zmap.c
@@ -359,7 +359,7 @@ static int z_erofs_extent_lookback(struct z_erofs_maprecorder *m,
return z_erofs_extent_lookback(m, m->delta[0]);
case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
map->m_flags &= ~EROFS_MAP_ZIPPED;
- /* fallthrough */
+ fallthrough;
case Z_EROFS_VLE_CLUSTER_TYPE_HEAD:
map->m_la = (lcn << lclusterbits) | m->clusterofs;
break;
@@ -416,7 +416,7 @@ int z_erofs_map_blocks_iter(struct inode *inode,
case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
if (endoff >= m.clusterofs)
map->m_flags &= ~EROFS_MAP_ZIPPED;
- /* fallthrough */
+ fallthrough;
case Z_EROFS_VLE_CLUSTER_TYPE_HEAD:
if (endoff >= m.clusterofs) {
map->m_la = (m.lcn << lclusterbits) | m.clusterofs;
@@ -433,7 +433,7 @@ int z_erofs_map_blocks_iter(struct inode *inode,
end = (m.lcn << lclusterbits) | m.clusterofs;
map->m_flags |= EROFS_MAP_FULL_MAPPED;
m.delta[0] = 1;
- /* fallthrough */
+ fallthrough;
case Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD:
/* get the correspoinding first chunk */
err = z_erofs_extent_lookback(&m, m.delta[0]);
--
2.19.1

2020-08-10 03:41:12

by Chao Yu

Subject: Re: [PATCH] erofs: Convert to use the fallthrough macro

On 2020/8/8 17:21, linmiaohe wrote:
> From: Miaohe Lin <[email protected]>
>
> Convert the uses of fallthrough comments to fallthrough macro.
>
> Signed-off-by: Hongxiang Lou <[email protected]>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2020-08-10 12:16:43

by Gao Xiang

Subject: Re: [PATCH] erofs: Convert to use the fallthrough macro

On Mon, Aug 10, 2020 at 11:39:42AM +0800, Chao Yu wrote:
> On 2020/8/8 17:21, linmiaohe wrote:
> > From: Miaohe Lin <[email protected]>
> >
> > Convert the uses of fallthrough comments to fallthrough macro.
> >
> > Signed-off-by: Hongxiang Lou <[email protected]>
> > Signed-off-by: Miaohe Lin <[email protected]>
>
> Reviewed-by: Chao Yu <[email protected]>

Looks good to me too,

Reviewed-by: Gao Xiang <[email protected]>

(Although it seems some exist discussions here, e.g.,
https://lore.kernel.org/r/[email protected]
Will confirm that before the next cycle.)

Thanks,
Gao Xiang

>
> Thanks,
>