2020-08-10 08:33:08

by Colin King

Subject: [PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"

From: Colin Ian King <[email protected]>

There is a spelling mistake in a usb_stor_dbg debug message. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/usb/storage/isd200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
index 89f5e33a6e6d..3c76336e43bb 100644
--- a/drivers/usb/storage/isd200.c
+++ b/drivers/usb/storage/isd200.c
@@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
isd200_srb_set_bufflen(srb, 0);
} else {
- usb_stor_dbg(us, " Not removeable media, just report okay\n");
+ usb_stor_dbg(us, " Not removable media, just report okay\n");
srb->result = SAM_STAT_GOOD;
sendToTransport = 0;
}
--
2.27.0

2020-08-10 14:29:57

by Alan Stern

Subject: Re: [PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"

On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a spelling mistake in a usb_stor_dbg debug message. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/usb/storage/isd200.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
> index 89f5e33a6e6d..3c76336e43bb 100644
> --- a/drivers/usb/storage/isd200.c
> +++ b/drivers/usb/storage/isd200.c
> @@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
> ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
> isd200_srb_set_bufflen(srb, 0);
> } else {
> - usb_stor_dbg(us, " Not removeable media, just report okay\n");
> + usb_stor_dbg(us, " Not removable media, just report okay\n");
> srb->result = SAM_STAT_GOOD;
> sendToTransport = 0;
> }
> --

Acked-by: Alan Stern <[email protected]>

2020-08-10 17:17:46

by Joe Perches

Subject: Re: [PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"

On Mon, 2020-08-10 at 10:25 -0400, Alan Stern wrote:
> On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > There is a spelling mistake in a usb_stor_dbg debug message. Fix it.

This is an alternate spelling in a few dictionaries.
Is this an acceptable Briticism?
If so, I suggest no change.

> > diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
[]
> > @@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
> > ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
> > isd200_srb_set_bufflen(srb, 0);
> > } else {
> > - usb_stor_dbg(us, " Not removeable media, just report okay\n");
> > + usb_stor_dbg(us, " Not removable media, just report okay\n");
> > srb->result = SAM_STAT_GOOD;
> > sendToTransport = 0;
> > }
> > --
>
> Acked-by: Alan Stern <[email protected]>

2020-08-10 17:29:16

by Colin King

Subject: Re: [PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"

On 10/08/2020 18:14, Joe Perches wrote:
> On Mon, 2020-08-10 at 10:25 -0400, Alan Stern wrote:
>> On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
>>> From: Colin Ian King <[email protected]>
>>>
>>> There is a spelling mistake in a usb_stor_dbg debug message. Fix it.
>
> This is an alternate spelling in a few dictionaries.
> Is this an acceptable Briticism?
> If so, I suggest no change.

I was keeping it consistent with all the other occurrences of this word
in kernel messages.

>
>>> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
> []
>>> @@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
>>> ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
>>> isd200_srb_set_bufflen(srb, 0);
>>> } else {
>>> - usb_stor_dbg(us, " Not removeable media, just report okay\n");
>>> + usb_stor_dbg(us, " Not removable media, just report okay\n");
>>> srb->result = SAM_STAT_GOOD;
>>> sendToTransport = 0;
>>> }
>>> --
>>
>> Acked-by: Alan Stern <[email protected]>
>