2020-08-12 14:39:12

by Bean Huo

Subject: [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu()

From: Bean Huo <[email protected]>

ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request
completion calling function. Change it to ufshcd_compose_devman_upiu().

Signed-off-by: Bean Huo <[email protected]>
Acked-by: Avri Altman <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5f09cda7b21c..e3663b85e8ee 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -2391,12 +2391,13 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp)
}

/**
- * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU)
+ * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU)
* for Device Management Purposes
* @hba: per adapter instance
* @lrbp: pointer to local reference block
*/
-static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
+static int ufshcd_compose_devman_upiu(struct ufs_hba *hba,
+ struct ufshcd_lrb *lrbp)
{
u8 upiu_flags;
int ret = 0;
@@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba,
ufshcd_prepare_lrbp_crypto(NULL, lrbp);
hba->dev_cmd.type = cmd_type;

- return ufshcd_comp_devman_upiu(hba, lrbp);
+ return ufshcd_compose_devman_upiu(hba, lrbp);
}

static int
--
2.17.1

2020-08-13 15:56:29

by Asutosh Das (asd)

Subject: Re: [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu()

On Wed, Aug 12 2020 at 07:37 -0700, Bean Huo wrote:
>From: Bean Huo <[email protected]>
>
>ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request
>completion calling function. Change it to ufshcd_compose_devman_upiu().
>
>Signed-off-by: Bean Huo <[email protected]>
>Acked-by: Avri Altman <[email protected]>

Reviewed-by: Asutosh Das <[email protected]>

>---
> drivers/scsi/ufs/ufshcd.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>index 5f09cda7b21c..e3663b85e8ee 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -2391,12 +2391,13 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp)
> }
>
> /**
>- * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU)
>+ * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU)
> * for Device Management Purposes
> * @hba: per adapter instance
> * @lrbp: pointer to local reference block
> */
>-static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
>+static int ufshcd_compose_devman_upiu(struct ufs_hba *hba,
>+ struct ufshcd_lrb *lrbp)
> {
> u8 upiu_flags;
> int ret = 0;
>@@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba,
> ufshcd_prepare_lrbp_crypto(NULL, lrbp);
> hba->dev_cmd.type = cmd_type;
>
>- return ufshcd_comp_devman_upiu(hba, lrbp);
>+ return ufshcd_compose_devman_upiu(hba, lrbp);
> }
>
> static int
>--
>2.17.1
>

2020-08-14 10:05:32

by Can Guo

Subject: Re: [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu()

On 2020-08-13 23:55, Asutosh Das wrote:
> On Wed, Aug 12 2020 at 07:37 -0700, Bean Huo wrote:
>> From: Bean Huo <[email protected]>
>>
>> ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request
>> completion calling function. Change it to
>> ufshcd_compose_devman_upiu().
>>
>> Signed-off-by: Bean Huo <[email protected]>
>> Acked-by: Avri Altman <[email protected]>
>
> Reviewed-by: Asutosh Das <[email protected]>

Reviewed-by: Can Guo <[email protected]>

>
>> ---
>> drivers/scsi/ufs/ufshcd.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 5f09cda7b21c..e3663b85e8ee 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -2391,12 +2391,13 @@ static inline void
>> ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp)
>> }
>>
>> /**
>> - * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU)
>> + * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU)
>> * for Device Management Purposes
>> * @hba: per adapter instance
>> * @lrbp: pointer to local reference block
>> */
>> -static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct
>> ufshcd_lrb *lrbp)
>> +static int ufshcd_compose_devman_upiu(struct ufs_hba *hba,
>> + struct ufshcd_lrb *lrbp)
>> {
>> u8 upiu_flags;
>> int ret = 0;
>> @@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba
>> *hba,
>> ufshcd_prepare_lrbp_crypto(NULL, lrbp);
>> hba->dev_cmd.type = cmd_type;
>>
>> - return ufshcd_comp_devman_upiu(hba, lrbp);
>> + return ufshcd_compose_devman_upiu(hba, lrbp);
>> }
>>
>> static int
>> -- 2.17.1
>>