2020-08-13 17:16:02

by Prabhakar Mahadev Lad

Subject: [PATCH v3 3/3] media: i2c: ov5640: Fail probe on unsupported bus_type

Fail probe if unsupported bus_type is detected.

Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/media/i2c/ov5640.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 160d2857352a..3191e2b223c3 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -3078,6 +3078,13 @@ static int ov5640_probe(struct i2c_client *client)
return ret;
}

+ if (sensor->ep.bus_type != V4L2_MBUS_PARALLEL &&
+ sensor->ep.bus_type != V4L2_MBUS_CSI2_DPHY &&
+ sensor->ep.bus_type != V4L2_MBUS_BT656) {
+ dev_err(dev, "Unsupported bus type %d\n", sensor->ep.bus_type);
+ return -EINVAL;
+ }
+
/* get system clock (xclk) */
sensor->xclk = devm_clk_get(dev, "xclk");
if (IS_ERR(sensor->xclk)) {
--
2.17.1

2020-09-04 10:43:37

by jacopo mondi

Subject: Re: [PATCH v3 3/3] media: i2c: ov5640: Fail probe on unsupported bus_type

Hi Prabhakar

On Thu, Aug 13, 2020 at 06:13:37PM +0100, Lad Prabhakar wrote:
> Fail probe if unsupported bus_type is detected.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Thanks

Reviewed-by: Jacopo Mondi <[email protected]>


> ---
> drivers/media/i2c/ov5640.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 160d2857352a..3191e2b223c3 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -3078,6 +3078,13 @@ static int ov5640_probe(struct i2c_client *client)
> return ret;
> }
>
> + if (sensor->ep.bus_type != V4L2_MBUS_PARALLEL &&
> + sensor->ep.bus_type != V4L2_MBUS_CSI2_DPHY &&
> + sensor->ep.bus_type != V4L2_MBUS_BT656) {
> + dev_err(dev, "Unsupported bus type %d\n", sensor->ep.bus_type);
> + return -EINVAL;
> + }
> +
> /* get system clock (xclk) */
> sensor->xclk = devm_clk_get(dev, "xclk");
> if (IS_ERR(sensor->xclk)) {
> --
> 2.17.1
>