2020-08-14 01:46:23

by Wenbin Mei (梅文彬)

[permalink] [raw]
Subject: [v5,2/3] arm64: dts: mt7622: add reset node for mmc device

This commit adds reset node for mmc device.

Cc: <[email protected]> # v5.4+
Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Signed-off-by: Wenbin Mei <[email protected]>
Tested-by: Frank Wunderlich <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 1a39e0ef776b..5b9ec032ce8d 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -686,6 +686,8 @@
clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
<&topckgen CLK_TOP_MSDC50_0_SEL>;
clock-names = "source", "hclk";
+ resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
+ reset-names = "hrst";
status = "disabled";
};

--
2.18.0


2020-08-24 09:52:27

by Ulf Hansson

[permalink] [raw]
Subject: Re: [v5,2/3] arm64: dts: mt7622: add reset node for mmc device

On Fri, 14 Aug 2020 at 03:44, Wenbin Mei <[email protected]> wrote:
>
> This commit adds reset node for mmc device.
>
> Cc: <[email protected]> # v5.4+
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Signed-off-by: Wenbin Mei <[email protected]>
> Tested-by: Frank Wunderlich <[email protected]>

I can pick this for my fixes branch, together with the other changes,
however deferring that until Matthias acks it.

Kind regards
Uffe



> ---
> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 1a39e0ef776b..5b9ec032ce8d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -686,6 +686,8 @@
> clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
> <&topckgen CLK_TOP_MSDC50_0_SEL>;
> clock-names = "source", "hclk";
> + resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
> + reset-names = "hrst";
> status = "disabled";
> };
>
> --
> 2.18.0

2020-08-27 08:26:18

by Matthias Brugger

[permalink] [raw]
Subject: Re: [v5,2/3] arm64: dts: mt7622: add reset node for mmc device



On 24/08/2020 11:50, Ulf Hansson wrote:
> On Fri, 14 Aug 2020 at 03:44, Wenbin Mei <[email protected]> wrote:
>>
>> This commit adds reset node for mmc device.
>>
>> Cc: <[email protected]> # v5.4+
>> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
>> Signed-off-by: Wenbin Mei <[email protected]>
>> Tested-by: Frank Wunderlich <[email protected]>
>
> I can pick this for my fixes branch, together with the other changes,
> however deferring that until Matthias acks it.

Acked-by: Matthias Brugger <[email protected]>

My understanding is, that this will land also in v5.9-rc[3,4], correct?

Regards,
Matthias

>
> Kind regards
> Uffe
>
>
>
>> ---
>> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> index 1a39e0ef776b..5b9ec032ce8d 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> @@ -686,6 +686,8 @@
>> clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
>> <&topckgen CLK_TOP_MSDC50_0_SEL>;
>> clock-names = "source", "hclk";
>> + resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
>> + reset-names = "hrst";
>> status = "disabled";
>> };
>>
>> --
>> 2.18.0

2020-08-28 08:45:21

by Ulf Hansson

[permalink] [raw]
Subject: Re: [v5,2/3] arm64: dts: mt7622: add reset node for mmc device

On Thu, 27 Aug 2020 at 10:23, Matthias Brugger <[email protected]> wrote:
>
>
>
> On 24/08/2020 11:50, Ulf Hansson wrote:
> > On Fri, 14 Aug 2020 at 03:44, Wenbin Mei <[email protected]> wrote:
> >>
> >> This commit adds reset node for mmc device.
> >>
> >> Cc: <[email protected]> # v5.4+
> >> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> >> Signed-off-by: Wenbin Mei <[email protected]>
> >> Tested-by: Frank Wunderlich <[email protected]>
> >
> > I can pick this for my fixes branch, together with the other changes,
> > however deferring that until Matthias acks it.
>
> Acked-by: Matthias Brugger <[email protected]>
>
> My understanding is, that this will land also in v5.9-rc[3,4], correct?

Correct.

Applied for fixes, thanks!

[...]

Kind regards
Uffe