2020-08-18 08:50:32

by Xu, Yanfei

Subject: [PATCH] mm/memory.c: Replace vmf->vma with variable vma

From: Yanfei Xu <[email protected]>

The code has declared a vma_struct named vma which is assigned a
value of vmf->vma. Thus, use variable vma directly here.

Signed-off-by: Yanfei Xu <[email protected]>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index 9cc3d0dc816c..88f61b4f9638 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3454,7 +3454,7 @@ static vm_fault_t __do_fault(struct vm_fault *vmf)
* # flush A, B to clear the writeback
*/
if (pmd_none(*vmf->pmd) && !vmf->prealloc_pte) {
- vmf->prealloc_pte = pte_alloc_one(vmf->vma->vm_mm);
+ vmf->prealloc_pte = pte_alloc_one(vma->vm_mm);
if (!vmf->prealloc_pte)
return VM_FAULT_OOM;
smp_wmb(); /* See comment in __pte_alloc() */
--
2.18.2

2020-08-18 12:03:14

by Matthew Wilcox

Subject: Re: [PATCH] mm/memory.c: Replace vmf->vma with variable vma

On Tue, Aug 18, 2020 at 04:46:07PM +0800, [email protected] wrote:
> From: Yanfei Xu <[email protected]>
>
> The code has declared a vma_struct named vma which is assigned a
> value of vmf->vma. Thus, use variable vma directly here.
>
> Signed-off-by: Yanfei Xu <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>