2020-08-18 09:53:26

by Nicolin Chen

[permalink] [raw]
Subject: [PATCH] memory: tegra: Correct shift value of apew

According to Tegra X1 (Tegra210) TRM, the APEW field is between
[23:16] so the shift bit for apew should be 16 accordingly.

Signed-off-by: Nicolin Chen <[email protected]>
---
drivers/memory/tegra/tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra210.c
index eab4bc01c8bc..51b537cfa5a7 100644
--- a/drivers/memory/tegra/tegra210.c
+++ b/drivers/memory/tegra/tegra210.c
@@ -842,7 +842,7 @@ static const struct tegra_mc_client tegra210_mc_clients[] = {
},
.la = {
.reg = 0x3dc,
- .shift = 0,
+ .shift = 16,
.mask = 0xff,
.def = 0x80,
},
--
2.17.1


2020-08-20 15:29:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] memory: tegra: Correct shift value of apew

On Tue, Aug 18, 2020 at 02:51:21AM -0700, Nicolin Chen wrote:
> According to Tegra X1 (Tegra210) TRM, the APEW field is between
> [23:16] so the shift bit for apew should be 16 accordingly.
>
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
> drivers/memory/tegra/tegra210.c | 2 +-

Thanks, applied to drivers/memory.

Best regards,
Krzysztof