Introduce new option on devlink reload API to enable the user to select the
reload action required. Complete support for all actions in mlx5.
The following reload actions are supported:
fw_live_patch: firmware live patching.
driver_reinit: driver entities re-initialization, applying devlink-params
and devlink-resources values.
fw_activate: firmware activate.
Each driver which support this command should expose the reload actions
supported.
The uAPI is backward compatible, if the reload action option is omitted
from the reload command, the driver reinit action will be used.
Note that when required to do firmware activation some drivers may need
to reload the driver. On the other hand some drivers may need to reset
the firmware to reinitialize the driver entities.
Patch 1 adds the new API reload action option to devlink.
Patch 2 exposes the supported reload actions on devlink dev get.
Patches 3-8 add support on mlx5 for devlink reload action fw_activate
and handle the firmware reset events.
Patches 9-10 add devlink enable remote dev reset parameter and use it
in mlx5.
Patches 11-12 mlx5 add devlink reload live patch support and event
handling.
Patch 13 adds documentation file devlink-reload.rst
Command examples:
# Run reload command with fw activate reload action:
$ devlink dev reload pci/0000:82:00.0 action fw_activate
# Run reload command with driver reload action:
$ devlink dev reload pci/0000:82:00.0 action driver_reinit
# Run reload command with fw live patch reload action:
$ devlink dev reload pci/0000:82:00.0 action fw_live_patch
v1 -> v2:
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_activate,fw_live_patch
- Remove driver default level, the action driver_reinit is the default
action for all drivers
Moshe Shemesh (13):
devlink: Add reload action option to devlink reload command
devlink: Add supported reload actions to dev get
net/mlx5: Add functions to set/query MFRL register
net/mlx5: Set cap for pci sync for fw update event
net/mlx5: Handle sync reset request event
net/mlx5: Handle sync reset now event
net/mlx5: Handle sync reset abort event
net/mlx5: Add support for devlink reload action fw activate
devlink: Add enable_remote_dev_reset generic parameter
net/mlx5: Add devlink param enable_remote_dev_reset support
net/mlx5: Add support for fw live patch event
net/mlx5: Add support for devlink reload action live patch
devlink: Add Documentation/networking/devlink/devlink-reload.rst
.../networking/devlink/devlink-params.rst | 6 +
.../networking/devlink/devlink-reload.rst | 54 +++
Documentation/networking/devlink/index.rst | 1 +
drivers/net/ethernet/mellanox/mlx4/main.c | 4 +-
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../net/ethernet/mellanox/mlx5/core/devlink.c | 104 +++-
.../mellanox/mlx5/core/diag/fw_tracer.c | 31 ++
.../mellanox/mlx5/core/diag/fw_tracer.h | 1 +
.../ethernet/mellanox/mlx5/core/fw_reset.c | 448 ++++++++++++++++++
.../ethernet/mellanox/mlx5/core/fw_reset.h | 19 +
.../net/ethernet/mellanox/mlx5/core/health.c | 35 +-
.../net/ethernet/mellanox/mlx5/core/main.c | 13 +
.../ethernet/mellanox/mlx5/core/mlx5_core.h | 2 +
drivers/net/ethernet/mellanox/mlxsw/core.c | 6 +-
drivers/net/netdevsim/dev.c | 5 +-
include/linux/mlx5/device.h | 1 +
include/linux/mlx5/driver.h | 4 +
include/net/devlink.h | 9 +-
include/uapi/linux/devlink.h | 20 +
net/core/devlink.c | 84 +++-
20 files changed, 812 insertions(+), 37 deletions(-)
create mode 100644 Documentation/networking/devlink/devlink-reload.rst
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c
create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/fw_reset.h
--
2.17.1
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index ce43e3feccd9..871d28b09f8a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -548,6 +548,9 @@ static int handle_hca_cap(struct mlx5_core_dev *dev, void *set_ctx)
if (MLX5_CAP_GEN_MAX(dev, dct))
MLX5_SET(cmd_hca_cap, set_hca_cap, dct, 1);
+ if (MLX5_CAP_GEN_MAX(dev, pci_sync_for_fw_update_event))
+ MLX5_SET(cmd_hca_cap, set_hca_cap, pci_sync_for_fw_update_event, 1);
+
if (MLX5_CAP_GEN_MAX(dev, num_vhca_ports))
MLX5_SET(cmd_hca_cap,
set_hca_cap,
--
2.17.1
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh <[email protected]>
---
- Instead of reload levels driver,fw_reset,fw_live_patch have reload
actions driver_reinit,fw_activate,fw_live_patch
---
.../networking/devlink/devlink-reload.rst | 54 +++++++++++++++++++
Documentation/networking/devlink/index.rst | 1 +
2 files changed, 55 insertions(+)
create mode 100644 Documentation/networking/devlink/devlink-reload.rst
diff --git a/Documentation/networking/devlink/devlink-reload.rst b/Documentation/networking/devlink/devlink-reload.rst
new file mode 100644
index 000000000000..9846ea727f3b
--- /dev/null
+++ b/Documentation/networking/devlink/devlink-reload.rst
@@ -0,0 +1,54 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+==============
+Devlink Reload
+==============
+
+``devlink-reload`` provides mechanism to either reload driver entities,
+applying ``devlink-params`` and ``devlink-resources`` new values or firmware
+activation depends on reload action selected.
+
+Reload actions
+=============
+
+User may select a reload action.
+By default ``driver_reinit`` action is done.
+
+.. list-table:: Possible reload actions
+ :widths: 5 90
+
+ * - Name
+ - Description
+ * - ``driver-reinit``
+ - Driver entities re-initialization, including applying
+ new values to devlink entities which are used during driver
+ load such as ``devlink-params`` in configuration mode
+ ``driverinit`` or ``devlink-resources``
+ * - ``fw_activate``
+ - Firmware activate. Can be used for firmware reload or firmware
+ upgrade if new firmware is stored and driver supports such
+ firmware upgrade.
+ * - ``fw_live_patch``
+ - Firmware live patch, applies firmware changes without reset.
+
+Change namespace
+================
+
+All devlink instances are created in init_net and stay there for a
+lifetime. Allow user to be able to move devlink instances into
+namespaces during devlink reload operation. That ensures proper
+re-instantiation of driver objects, including netdevices.
+
+example usage
+-------------
+
+.. code:: shell
+
+ $ devlink dev reload help
+ $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { fw_live_patch | driver_reinit | fw_activate } ]
+
+ # Run reload command for devlink driver entities re-initialization:
+ $ devlink dev reload pci/0000:82:00.0 action driver_reinit
+
+ # Run reload command to activate firmware:
+ $ devlink dev reload pci/0000:82:00.0 action fw_activate
diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst
index 7684ae5c4a4a..d82874760ae2 100644
--- a/Documentation/networking/devlink/index.rst
+++ b/Documentation/networking/devlink/index.rst
@@ -20,6 +20,7 @@ general.
devlink-params
devlink-region
devlink-resource
+ devlink-reload
devlink-trap
Driver-specific documentation
--
2.17.1
Mon, Aug 17, 2020 at 11:37:52AM CEST, [email protected] wrote:
>Add devlink reload rst documentation file.
>Update index file to include it.
>
>Signed-off-by: Moshe Shemesh <[email protected]>
>---
>- Instead of reload levels driver,fw_reset,fw_live_patch have reload
> actions driver_reinit,fw_activate,fw_live_patch
>---
> .../networking/devlink/devlink-reload.rst | 54 +++++++++++++++++++
> Documentation/networking/devlink/index.rst | 1 +
> 2 files changed, 55 insertions(+)
> create mode 100644 Documentation/networking/devlink/devlink-reload.rst
>
>diff --git a/Documentation/networking/devlink/devlink-reload.rst b/Documentation/networking/devlink/devlink-reload.rst
>new file mode 100644
>index 000000000000..9846ea727f3b
>--- /dev/null
>+++ b/Documentation/networking/devlink/devlink-reload.rst
>@@ -0,0 +1,54 @@
>+.. SPDX-License-Identifier: GPL-2.0
>+
>+==============
>+Devlink Reload
>+==============
>+
>+``devlink-reload`` provides mechanism to either reload driver entities,
>+applying ``devlink-params`` and ``devlink-resources`` new values or firmware
>+activation depends on reload action selected.
>+
>+Reload actions
>+=============
>+
>+User may select a reload action.
>+By default ``driver_reinit`` action is done.
>+
>+.. list-table:: Possible reload actions
>+ :widths: 5 90
>+
>+ * - Name
>+ - Description
>+ * - ``driver-reinit``
>+ - Driver entities re-initialization, including applying
>+ new values to devlink entities which are used during driver
>+ load such as ``devlink-params`` in configuration mode
>+ ``driverinit`` or ``devlink-resources``
>+ * - ``fw_activate``
>+ - Firmware activate. Can be used for firmware reload or firmware
>+ upgrade if new firmware is stored and driver supports such
>+ firmware upgrade.
Does this do the same as "driver-reinit" + fw activation? If yes, it
should be written here. If no, it should be written here as well.
>+ * - ``fw_live_patch``
>+ - Firmware live patch, applies firmware changes without reset.
>+
>+Change namespace
>+================
>+
>+All devlink instances are created in init_net and stay there for a
>+lifetime. Allow user to be able to move devlink instances into
>+namespaces during devlink reload operation. That ensures proper
>+re-instantiation of driver objects, including netdevices.
>+
>+example usage
>+-------------
>+
>+.. code:: shell
>+
>+ $ devlink dev reload help
>+ $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { fw_live_patch | driver_reinit | fw_activate } ]
>+
>+ # Run reload command for devlink driver entities re-initialization:
>+ $ devlink dev reload pci/0000:82:00.0 action driver_reinit
>+
>+ # Run reload command to activate firmware:
>+ $ devlink dev reload pci/0000:82:00.0 action fw_activate
>diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst
>index 7684ae5c4a4a..d82874760ae2 100644
>--- a/Documentation/networking/devlink/index.rst
>+++ b/Documentation/networking/devlink/index.rst
>@@ -20,6 +20,7 @@ general.
> devlink-params
> devlink-region
> devlink-resource
>+ devlink-reload
> devlink-trap
>
> Driver-specific documentation
>--
>2.17.1
>
On 8/17/2020 7:39 PM, Jiri Pirko wrote:
> Mon, Aug 17, 2020 at 11:37:52AM CEST, [email protected] wrote:
>> Add devlink reload rst documentation file.
>> Update index file to include it.
>>
>> Signed-off-by: Moshe Shemesh <[email protected]>
>> ---
>> - Instead of reload levels driver,fw_reset,fw_live_patch have reload
>> actions driver_reinit,fw_activate,fw_live_patch
>> ---
>> .../networking/devlink/devlink-reload.rst | 54 +++++++++++++++++++
>> Documentation/networking/devlink/index.rst | 1 +
>> 2 files changed, 55 insertions(+)
>> create mode 100644 Documentation/networking/devlink/devlink-reload.rst
>>
>> diff --git a/Documentation/networking/devlink/devlink-reload.rst b/Documentation/networking/devlink/devlink-reload.rst
>> new file mode 100644
>> index 000000000000..9846ea727f3b
>> --- /dev/null
>> +++ b/Documentation/networking/devlink/devlink-reload.rst
>> @@ -0,0 +1,54 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +==============
>> +Devlink Reload
>> +==============
>> +
>> +``devlink-reload`` provides mechanism to either reload driver entities,
>> +applying ``devlink-params`` and ``devlink-resources`` new values or firmware
>> +activation depends on reload action selected.
>> +
>> +Reload actions
>> +=============
>> +
>> +User may select a reload action.
>> +By default ``driver_reinit`` action is done.
>> +
>> +.. list-table:: Possible reload actions
>> + :widths: 5 90
>> +
>> + * - Name
>> + - Description
>> + * - ``driver-reinit``
>> + - Driver entities re-initialization, including applying
>> + new values to devlink entities which are used during driver
>> + load such as ``devlink-params`` in configuration mode
>> + ``driverinit`` or ``devlink-resources``
>> + * - ``fw_activate``
>> + - Firmware activate. Can be used for firmware reload or firmware
>> + upgrade if new firmware is stored and driver supports such
>> + firmware upgrade.
> Does this do the same as "driver-reinit" + fw activation? If yes, it
> should be written here. If no, it should be written here as well.
>
No, The only thing required here is the action of firmware activation.
If a driver needs to do reload to make that happen and do reinit that's
ok, but not required.
>> + * - ``fw_live_patch``
>> + - Firmware live patch, applies firmware changes without reset.
>> +
>> +Change namespace
>> +================
>> +
>> +All devlink instances are created in init_net and stay there for a
>> +lifetime. Allow user to be able to move devlink instances into
>> +namespaces during devlink reload operation. That ensures proper
>> +re-instantiation of driver objects, including netdevices.
>> +
>> +example usage
>> +-------------
>> +
>> +.. code:: shell
>> +
>> + $ devlink dev reload help
>> + $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { fw_live_patch | driver_reinit | fw_activate } ]
>> +
>> + # Run reload command for devlink driver entities re-initialization:
>> + $ devlink dev reload pci/0000:82:00.0 action driver_reinit
>> +
>> + # Run reload command to activate firmware:
>> + $ devlink dev reload pci/0000:82:00.0 action fw_activate
>> diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst
>> index 7684ae5c4a4a..d82874760ae2 100644
>> --- a/Documentation/networking/devlink/index.rst
>> +++ b/Documentation/networking/devlink/index.rst
>> @@ -20,6 +20,7 @@ general.
>> devlink-params
>> devlink-region
>> devlink-resource
>> + devlink-reload
>> devlink-trap
>>
>> Driver-specific documentation
>> --
>> 2.17.1
>>
Tue, Aug 18, 2020 at 11:14:16AM CEST, [email protected] wrote:
>
>On 8/17/2020 7:39 PM, Jiri Pirko wrote:
>> Mon, Aug 17, 2020 at 11:37:52AM CEST, [email protected] wrote:
>> > Add devlink reload rst documentation file.
>> > Update index file to include it.
>> >
>> > Signed-off-by: Moshe Shemesh <[email protected]>
>> > ---
>> > - Instead of reload levels driver,fw_reset,fw_live_patch have reload
>> > actions driver_reinit,fw_activate,fw_live_patch
>> > ---
>> > .../networking/devlink/devlink-reload.rst | 54 +++++++++++++++++++
>> > Documentation/networking/devlink/index.rst | 1 +
>> > 2 files changed, 55 insertions(+)
>> > create mode 100644 Documentation/networking/devlink/devlink-reload.rst
>> >
>> > diff --git a/Documentation/networking/devlink/devlink-reload.rst b/Documentation/networking/devlink/devlink-reload.rst
>> > new file mode 100644
>> > index 000000000000..9846ea727f3b
>> > --- /dev/null
>> > +++ b/Documentation/networking/devlink/devlink-reload.rst
>> > @@ -0,0 +1,54 @@
>> > +.. SPDX-License-Identifier: GPL-2.0
>> > +
>> > +==============
>> > +Devlink Reload
>> > +==============
>> > +
>> > +``devlink-reload`` provides mechanism to either reload driver entities,
>> > +applying ``devlink-params`` and ``devlink-resources`` new values or firmware
>> > +activation depends on reload action selected.
>> > +
>> > +Reload actions
>> > +=============
>> > +
>> > +User may select a reload action.
>> > +By default ``driver_reinit`` action is done.
>> > +
>> > +.. list-table:: Possible reload actions
>> > + :widths: 5 90
>> > +
>> > + * - Name
>> > + - Description
>> > + * - ``driver-reinit``
>> > + - Driver entities re-initialization, including applying
>> > + new values to devlink entities which are used during driver
>> > + load such as ``devlink-params`` in configuration mode
>> > + ``driverinit`` or ``devlink-resources``
>> > + * - ``fw_activate``
>> > + - Firmware activate. Can be used for firmware reload or firmware
>> > + upgrade if new firmware is stored and driver supports such
>> > + firmware upgrade.
>> Does this do the same as "driver-reinit" + fw activation? If yes, it
>> should be written here. If no, it should be written here as well.
>>
>
>No, The only thing required here is the action of firmware activation. If a
>driver needs to do reload to make that happen and do reinit that's ok, but
>not required.
What does the "FW activation" mean? I believe that this needs explicit
documentation here.
>
>> > + * - ``fw_live_patch``
>> > + - Firmware live patch, applies firmware changes without reset.
>> > +
>> > +Change namespace
>> > +================
>> > +
>> > +All devlink instances are created in init_net and stay there for a
>> > +lifetime. Allow user to be able to move devlink instances into
>> > +namespaces during devlink reload operation. That ensures proper
>> > +re-instantiation of driver objects, including netdevices.
>> > +
>> > +example usage
>> > +-------------
>> > +
>> > +.. code:: shell
>> > +
>> > + $ devlink dev reload help
>> > + $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { fw_live_patch | driver_reinit | fw_activate } ]
>> > +
>> > + # Run reload command for devlink driver entities re-initialization:
>> > + $ devlink dev reload pci/0000:82:00.0 action driver_reinit
>> > +
>> > + # Run reload command to activate firmware:
>> > + $ devlink dev reload pci/0000:82:00.0 action fw_activate
>> > diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst
>> > index 7684ae5c4a4a..d82874760ae2 100644
>> > --- a/Documentation/networking/devlink/index.rst
>> > +++ b/Documentation/networking/devlink/index.rst
>> > @@ -20,6 +20,7 @@ general.
>> > devlink-params
>> > devlink-region
>> > devlink-resource
>> > + devlink-reload
>> > devlink-trap
>> >
>> > Driver-specific documentation
>> > --
>> > 2.17.1
>> >
On 8/18/2020 2:07 PM, Jiri Pirko wrote:
> Tue, Aug 18, 2020 at 11:14:16AM CEST, [email protected] wrote:
>> On 8/17/2020 7:39 PM, Jiri Pirko wrote:
>>> Mon, Aug 17, 2020 at 11:37:52AM CEST, [email protected] wrote:
>>>> Add devlink reload rst documentation file.
>>>> Update index file to include it.
>>>>
>>>> Signed-off-by: Moshe Shemesh <[email protected]>
>>>> ---
>>>> - Instead of reload levels driver,fw_reset,fw_live_patch have reload
>>>> actions driver_reinit,fw_activate,fw_live_patch
>>>> ---
>>>> .../networking/devlink/devlink-reload.rst | 54 +++++++++++++++++++
>>>> Documentation/networking/devlink/index.rst | 1 +
>>>> 2 files changed, 55 insertions(+)
>>>> create mode 100644 Documentation/networking/devlink/devlink-reload.rst
>>>>
>>>> diff --git a/Documentation/networking/devlink/devlink-reload.rst b/Documentation/networking/devlink/devlink-reload.rst
>>>> new file mode 100644
>>>> index 000000000000..9846ea727f3b
>>>> --- /dev/null
>>>> +++ b/Documentation/networking/devlink/devlink-reload.rst
>>>> @@ -0,0 +1,54 @@
>>>> +.. SPDX-License-Identifier: GPL-2.0
>>>> +
>>>> +==============
>>>> +Devlink Reload
>>>> +==============
>>>> +
>>>> +``devlink-reload`` provides mechanism to either reload driver entities,
>>>> +applying ``devlink-params`` and ``devlink-resources`` new values or firmware
>>>> +activation depends on reload action selected.
>>>> +
>>>> +Reload actions
>>>> +=============
>>>> +
>>>> +User may select a reload action.
>>>> +By default ``driver_reinit`` action is done.
>>>> +
>>>> +.. list-table:: Possible reload actions
>>>> + :widths: 5 90
>>>> +
>>>> + * - Name
>>>> + - Description
>>>> + * - ``driver-reinit``
>>>> + - Driver entities re-initialization, including applying
>>>> + new values to devlink entities which are used during driver
>>>> + load such as ``devlink-params`` in configuration mode
>>>> + ``driverinit`` or ``devlink-resources``
>>>> + * - ``fw_activate``
>>>> + - Firmware activate. Can be used for firmware reload or firmware
>>>> + upgrade if new firmware is stored and driver supports such
>>>> + firmware upgrade.
>>> Does this do the same as "driver-reinit" + fw activation? If yes, it
>>> should be written here. If no, it should be written here as well.
>>>
>> No, The only thing required here is the action of firmware activation. If a
>> driver needs to do reload to make that happen and do reinit that's ok, but
>> not required.
> What does the "FW activation" mean? I believe that this needs explicit
> documentation here.
>
I will add it explicitly.
FW activation means FW upgrade if new image is pending activation. If no
FW image pending, it reloads the current FW.
>>>> + * - ``fw_live_patch``
>>>> + - Firmware live patch, applies firmware changes without reset.
>>>> +
>>>> +Change namespace
>>>> +================
>>>> +
>>>> +All devlink instances are created in init_net and stay there for a
>>>> +lifetime. Allow user to be able to move devlink instances into
>>>> +namespaces during devlink reload operation. That ensures proper
>>>> +re-instantiation of driver objects, including netdevices.
>>>> +
>>>> +example usage
>>>> +-------------
>>>> +
>>>> +.. code:: shell
>>>> +
>>>> + $ devlink dev reload help
>>>> + $ devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { fw_live_patch | driver_reinit | fw_activate } ]
>>>> +
>>>> + # Run reload command for devlink driver entities re-initialization:
>>>> + $ devlink dev reload pci/0000:82:00.0 action driver_reinit
>>>> +
>>>> + # Run reload command to activate firmware:
>>>> + $ devlink dev reload pci/0000:82:00.0 action fw_activate
>>>> diff --git a/Documentation/networking/devlink/index.rst b/Documentation/networking/devlink/index.rst
>>>> index 7684ae5c4a4a..d82874760ae2 100644
>>>> --- a/Documentation/networking/devlink/index.rst
>>>> +++ b/Documentation/networking/devlink/index.rst
>>>> @@ -20,6 +20,7 @@ general.
>>>> devlink-params
>>>> devlink-region
>>>> devlink-resource
>>>> + devlink-reload
>>>> devlink-trap
>>>>
>>>> Driver-specific documentation
>>>> --
>>>> 2.17.1
>>>>