LinuxLists.cc - [PATCH 0/2] Novena laptop panel

2020-05-09 11:28:55

Subject: [PATCH 0/2] Novena laptop panel

From: Richard Marko <[email protected]>

Contains updated patches I've received from Marek with the following
changes:

- yaml docs migration
- fixed Fabios email
- panel commit split into two according to checkpatch request
- added connector for panel

Last review also requested more details for panel like timings and
bus format but these are marked as TBD (timings) in panel datasheet
and the bridge datasheet is not helpful either.

Tested on a Kosagi Novena laptop with imx6 display controller.

Based on v5.7-rc2, applies to drm-misc-next 5e6ed29d72d2

CC: Marek Vasut <[email protected]>
Cc: Sean Cross <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Thierry Reding <[email protected]>

Sean Cross (2):
dt-bindings: n133hse-ea1: Add Innolux N133HSE panel
drm/panel: simple: Add Innolux N133HSE panel support

.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++
2 files changed, 29 insertions(+)

base-commit: ae83d0b416db002fe95601e7f97f64b59514d936
--
2.25.1

2020-05-09 11:29:04

by srk

[permalink] [raw]

Subject: [PATCH 1/2] dt-bindings: n133hse-ea1: Add Innolux N133HSE panel

2020-05-09 11:29:05

by srk

[permalink] [raw]

Subject: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support

From: Sean Cross <[email protected]>

The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
integrated backlight, and connects via eDP.

It is used in the Kosagi Novena.

Signed-off-by: Sean Cross <[email protected]>
Signed-off-by: Richard Marko <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Thierry Reding <[email protected]>
To: [email protected]
---
drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ad828eaefe1..c8a93771d398 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
},
};

+static const struct drm_display_mode innolux_n133hse_ea1_mode = {
+ .clock = 138500,
+ .hdisplay = 1920,
+ .hsync_start = 1920 + 46,
+ .hsync_end = 1920 + 46 + 30,
+ .htotal = 1920 + 46 + 30 + 84,
+ .vdisplay = 1080,
+ .vsync_start = 1080 + 2,
+ .vsync_end = 1080 + 2 + 4,
+ .vtotal = 1080 + 2 + 4 + 26,
+ .vrefresh = 60,
+};
+
+static const struct panel_desc innolux_n133hse_ea1 = {
+ .modes = &innolux_n133hse_ea1_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 293,
+ .height = 165,
+ },
+ .connector_type = DRM_MODE_CONNECTOR_eDP,
+};
+
static const struct drm_display_mode innolux_n156bge_l21_mode = {
.clock = 69300,
.hdisplay = 1366,
@@ -3577,6 +3601,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,n116bge",
.data = &innolux_n116bge,
+ }, {
+ .compatible = "innolux,n133hse-ea1",
+ .data = &innolux_n133hse_ea1,
}, {
.compatible = "innolux,n156bge-l21",
.data = &innolux_n156bge_l21,
--
2.25.1

2020-05-11 07:50:09

by Sam Ravnborg

[permalink] [raw]

Subject: Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support

Hi Richard.

On Sat, May 09, 2020 at 01:18:34PM +0200, [email protected] wrote:
> From: Sean Cross <[email protected]>
>
> The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> integrated backlight, and connects via eDP.
>
> It is used in the Kosagi Novena.

Thanks for the patch.

>
> Signed-off-by: Sean Cross <[email protected]>
> Signed-off-by: Richard Marko <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: Thierry Reding <[email protected]>
> To: [email protected]
> ---
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..c8a93771d398 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
> },
> };
>
> +static const struct drm_display_mode innolux_n133hse_ea1_mode = {
> + .clock = 138500,
> + .hdisplay = 1920,
> + .hsync_start = 1920 + 46,
> + .hsync_end = 1920 + 46 + 30,
> + .htotal = 1920 + 46 + 30 + 84,
> + .vdisplay = 1080,
> + .vsync_start = 1080 + 2,
> + .vsync_end = 1080 + 2 + 4,
> + .vtotal = 1080 + 2 + 4 + 26,
> + .vrefresh = 60,
> +};
> +
> +static const struct panel_desc innolux_n133hse_ea1 = {
> + .modes = &innolux_n133hse_ea1_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 293,
> + .height = 165,
> + },
> + .connector_type = DRM_MODE_CONNECTOR_eDP,
Please include .bus_format and .bus_flags info too.

We are relying more and more on this type of info so we need it to be
present.

Sam

> +};
> +
> static const struct drm_display_mode innolux_n156bge_l21_mode = {
> .clock = 69300,
> .hdisplay = 1366,
> @@ -3577,6 +3601,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "innolux,n116bge",
> .data = &innolux_n116bge,
> + }, {
> + .compatible = "innolux,n133hse-ea1",
> + .data = &innolux_n133hse_ea1,
> }, {
> .compatible = "innolux,n156bge-l21",
> .data = &innolux_n156bge_l21,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2020-05-18 18:31:18

by Rob Herring

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: n133hse-ea1: Add Innolux N133HSE panel

On Sat, May 09, 2020 at 01:18:33PM +0200, [email protected] wrote:
> From: Sean Cross <[email protected]>
>
> The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> integrated backlight, and connects via eDP.
>
> It is used in the Kosagi Novena.
>
> Signed-off-by: Sean Cross <[email protected]>
> Signed-off-by: Richard Marko <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: Thierry Reding <[email protected]>
> To: [email protected]
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 393ffc6acbba..756bf6a48e8d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -139,6 +139,8 @@ properties:
> - innolux,g121i1-l01
> # Innolux Corporation 12.1" G121X1-L03 XGA (1024x768) TFT LCD panel
> - innolux,g121x1-l03
> + # Innolux Corporation 13.3" FHD (1920x1080) TFT LCD panel
> + - innolux,n133hse-ea1
> # Innolux Corporation 11.6" WXGA (1366x768) TFT LCD panel
> - innolux,n116bge

Alpha-numeric order please.

> # InnoLux 15.6" WXGA TFT LCD panel
> --
> 2.25.1
>

2020-08-19 13:05:26

by Lubomir Rintel

[permalink] [raw]

Subject: Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support

On Mon, May 11, 2020 at 09:47:08AM +0200, Sam Ravnborg wrote:
> Hi Richard.
>
> On Sat, May 09, 2020 at 01:18:34PM +0200, [email protected] wrote:
> > From: Sean Cross <[email protected]>
> >
> > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> > integrated backlight, and connects via eDP.
> >
> > It is used in the Kosagi Novena.
>
> Thanks for the patch.
>
>
> >
> > Signed-off-by: Sean Cross <[email protected]>
> > Signed-off-by: Richard Marko <[email protected]>
> > Cc: Shawn Guo <[email protected]>
> > Cc: Fabio Estevam <[email protected]>
> > Cc: Thierry Reding <[email protected]>
> > To: [email protected]
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..c8a93771d398 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
> > },
> > };
> >
> > +static const struct drm_display_mode innolux_n133hse_ea1_mode = {
> > + .clock = 138500,
> > + .hdisplay = 1920,
> > + .hsync_start = 1920 + 46,
> > + .hsync_end = 1920 + 46 + 30,
> > + .htotal = 1920 + 46 + 30 + 84,
> > + .vdisplay = 1080,
> > + .vsync_start = 1080 + 2,
> > + .vsync_end = 1080 + 2 + 4,
> > + .vtotal = 1080 + 2 + 4 + 26,
> > + .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc innolux_n133hse_ea1 = {
> > + .modes = &innolux_n133hse_ea1_mode,
> > + .num_modes = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 293,
> > + .height = 165,
> > + },
> > + .connector_type = DRM_MODE_CONNECTOR_eDP,
> Please include .bus_format and .bus_flags info too.
>
> We are relying more and more on this type of info so we need it to be
> present.

I am wondering which of the flags make sense for eDP and how the bus
format should be described?

Some eDP panels seems [1] to specify DRM_BUS_FLAG_DATA_MSB_TO_LSB and
DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, but I am not sure what sense they make
for packet data with embedded clock that eDP uses? (Unless, of course,
my understanding of eDP is entirely missing the point.)

This panel uses RGB888 data over two differential pairs. Would
format = MEDIA_BUS_FMT_RGB888_1X24 be appropriate?

[1] N133HSE-EA1 Datasheet
http://www.vslcd.com/specification/N133HSE-EA1.pdf

> Sam

Thank you,
Lubo