Hi all,
In commit
71aefb9a89d4 ("RAS/CEC: Fix cec_init() prototype")
Fixes tag
Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")
has these problem(s):
- The SHA1 is not all hex
Presumably
Fixes: 9554bfe403bd ("x86/mce: Convert the CEC to use the MCE notifier")
--
Cheers,
Stephen Rothwell
On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 71aefb9a89d4 ("RAS/CEC: Fix cec_init() prototype")
>
> Fixes tag
>
> Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")
Hmm, this came from the original patch submission:
https://lkml.kernel.org/r/[email protected]
the 'n' is already there.
> has these problem(s):
>
> - The SHA1 is not all hex
If your script which verifies that is in python, per chance, you could
give it to me so that I can add it to my patch massaging script. :-)
I have no Fixes: tags sanity checks so far and have never considered
that they could possibly be wrong but this here is a case-in-point
example.
I guess I'd need also an "is the commit ID an actual upstream commit ID"
check, while at it.
> Presumably
>
> Fixes: 9554bfe403bd ("x86/mce: Convert the CEC to use the MCE notifier")
Fixing...
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
Hi Borislav,
On Thu, 20 Aug 2020 10:21:49 +0200 Borislav Petkov <[email protected]> wrote:
>
> On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> >
> > Fixes tag
> >
> > Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")
>
> Hmm, this came from the original patch submission:
>
> https://lkml.kernel.org/r/[email protected]
>
> the 'n' is already there.
yeah, I wish people would just generate these lines:
git log -1 --format='Fixes: %h ("%s")' <commit-id>
> > has these problem(s):
> >
> > - The SHA1 is not all hex
>
> If your script which verifies that is in python, per chance, you could
> give it to me so that I can add it to my patch massaging script. :-)
Is a shell script OK?
--
Cheers,
Stephen Rothwell
Hey Stephen,
On Thu, Aug 20, 2020 at 07:15:02PM +1000, Stephen Rothwell wrote:
> yeah, I wish people would just generate these lines:
>
> git log -1 --format='Fixes: %h ("%s")' <commit-id>
Yap, but that "add invalid char" thing can happen when pasting the mail
in the mail client, etc. I've even seen maintainers botch tags...
> Is a shell script OK?
Nah, my script is in python. But no worries, I'll add that to it now,
since I even have an actual example to test it on.
Thx for catching this!
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
On Thu, Aug 20, 2020 at 07:15:02PM +1000, Stephen Rothwell wrote:
> On Thu, 20 Aug 2020 10:21:49 +0200 Borislav Petkov <[email protected]> wrote:
> >
> > On Thu, Aug 20, 2020 at 04:12:39PM +1000, Stephen Rothwell wrote:
> > >
> > > Fixes tag
> > >
> > > Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier")
> >
> > Hmm, this came from the original patch submission:
> >
> > https://lkml.kernel.org/r/[email protected]
> >
> > the 'n' is already there.
>
> yeah, I wish people would just generate these lines:
>
> git log -1 --format='Fixes: %h ("%s")' <commit-id>
FWIW, I'm using a script 'git-fixesline' that git also understands as a
subcommand 'git fixesline' with:
git --no-pager show -s --abbrev-commit --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")%n" "$@"
(Dunno why not an alias but it works the same way.)
On Thu, Aug 20, 2020 at 11:22:21AM +0200, David Sterba wrote:
> (Dunno why not an alias but it works the same way.)
I have this alias:
one = show -s --pretty='format:%h (\"%s\")'
and so I do
$ git one <sha1>
and then paste it after Fixes:
I have it this way because quoting commits is kinda very frequent
operation, not only for Fixes: tags.
:-)
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg