2020-08-19 18:47:44

by Ira Weiny

Subject: [PATCH] mm/highmem: Clean up endif comments

From: Ira Weiny <[email protected]>

The #endif at the end of the file matches up with the '#if
defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if
earlier.

Fix comments on both of the #endif's to indicate the correct end of
blocks for each.

Signed-off-by: Ira Weiny <[email protected]>
---
mm/highmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/highmem.c b/mm/highmem.c
index 64d8dea47dd1..1352a27951e3 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
}

EXPORT_SYMBOL(kunmap_high);
-#endif
+#endif /* CONFIG_HIGHMEM */

#if defined(HASHED_PAGE_VIRTUAL)

@@ -481,4 +481,4 @@ void __init page_address_init(void)
}
}

-#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
+#endif /* defined(HASHED_PAGE_VIRTUAL) */
--
2.25.1

2020-08-20 19:53:25

by Mike Rapoport

Subject: Re: [PATCH] mm/highmem: Clean up endif comments

On Wed, Aug 19, 2020 at 11:46:35AM -0700, [email protected] wrote:
> From: Ira Weiny <[email protected]>
>
> The #endif at the end of the file matches up with the '#if
> defined(HASHED_PAGE_VIRTUAL)' on line 374. Not the CONFIG_HIGHMEM #if
> earlier.
>
> Fix comments on both of the #endif's to indicate the correct end of
> blocks for each.
>
> Signed-off-by: Ira Weiny <[email protected]>

Reviewed-by: Mike Rapoport <[email protected]>

> ---
> mm/highmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 64d8dea47dd1..1352a27951e3 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -369,7 +369,7 @@ void kunmap_high(struct page *page)
> }
>
> EXPORT_SYMBOL(kunmap_high);
> -#endif
> +#endif /* CONFIG_HIGHMEM */
>
> #if defined(HASHED_PAGE_VIRTUAL)
>
> @@ -481,4 +481,4 @@ void __init page_address_init(void)
> }
> }
>
> -#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
> +#endif /* defined(HASHED_PAGE_VIRTUAL) */
> --
> 2.25.1
>
>

--
Sincerely yours,
Mike.