2020-08-20 17:56:54

by Mathieu Poirier

Subject: [PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

Add entries for perf tools elements related to the support of Arm CoreSight
and Arm SPE. Also lump in Arm and Arm64 architecture files to provide
coverage.

Signed-off-by: Mathieu Poirier <[email protected]>
---
V2:
- Completed fileset for SPE.
- Added Arm and Arm64 architecture files.

MAINTAINERS | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index deaafb617361..e76f7bb014ce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13569,12 +13569,18 @@ F: kernel/events/*
F: tools/lib/perf/
F: tools/perf/

-PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
+PERFORMANCE EVENTS SUBSYSTEM ARM64
R: John Garry <[email protected]>
R: Will Deacon <[email protected]>
+R: Mathieu Poirier <[email protected]>
+R: Leo Yan <[email protected]>
L: [email protected] (moderated for non-subscribers)
S: Supported
+F: tools/build/feature/test-libopencsd.c
+F: tools/perf/arch/arm*/
F: tools/perf/pmu-events/arch/arm64/
+F: tools/perf/util/arm-spe*
+F: tools/perf/util/cs-etm*

PERSONALITY HANDLING
M: Christoph Hellwig <[email protected]>
--
2.25.1

2020-08-21 08:59:55

by John Garry

Subject: Re: [PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

On 20/08/2020 18:55, Mathieu Poirier wrote:
> Add entries for perf tools elements related to the support of Arm CoreSight
> and Arm SPE. Also lump in Arm and Arm64 architecture files to provide
> coverage.
>
> Signed-off-by: Mathieu Poirier <[email protected]>

thanks
Acked-by: John Garry <[email protected]>

> ---
> V2:
> - Completed fileset for SPE.
> - Added Arm and Arm64 architecture files.
>
> MAINTAINERS | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index deaafb617361..e76f7bb014ce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13569,12 +13569,18 @@ F: kernel/events/*
> F: tools/lib/perf/
> F: tools/perf/
>
> -PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> +PERFORMANCE EVENTS SUBSYSTEM ARM64
> R: John Garry <[email protected]>
> R: Will Deacon <[email protected]>
> +R: Mathieu Poirier <[email protected]>
> +R: Leo Yan <[email protected]>
> L: [email protected] (moderated for non-subscribers)
> S: Supported
> +F: tools/build/feature/test-libopencsd.c
> +F: tools/perf/arch/arm*/
> F: tools/perf/pmu-events/arch/arm64/
> +F: tools/perf/util/arm-spe*
> +F: tools/perf/util/cs-etm*
>
> PERSONALITY HANDLING
> M: Christoph Hellwig <[email protected]>
>

2020-08-21 09:09:48

by Will Deacon

Subject: Re: [PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

On Thu, Aug 20, 2020 at 11:55:10AM -0600, Mathieu Poirier wrote:
> Add entries for perf tools elements related to the support of Arm CoreSight
> and Arm SPE. Also lump in Arm and Arm64 architecture files to provide
> coverage.
>
> Signed-off-by: Mathieu Poirier <[email protected]>
> ---
> V2:
> - Completed fileset for SPE.
> - Added Arm and Arm64 architecture files.
>
> MAINTAINERS | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index deaafb617361..e76f7bb014ce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13569,12 +13569,18 @@ F: kernel/events/*
> F: tools/lib/perf/
> F: tools/perf/
>
> -PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> +PERFORMANCE EVENTS SUBSYSTEM ARM64

I'd probably prefer to go with TOOLING instead of SUBSYSTEM, since the
kernel parts are covered by the "ARM PMU PROFILING AND DEBUGGING" entry.

> R: John Garry <[email protected]>
> R: Will Deacon <[email protected]>
> +R: Mathieu Poirier <[email protected]>
> +R: Leo Yan <[email protected]>
> L: [email protected] (moderated for non-subscribers)
> S: Supported
> +F: tools/build/feature/test-libopencsd.c
> +F: tools/perf/arch/arm*/
> F: tools/perf/pmu-events/arch/arm64/
> +F: tools/perf/util/arm-spe*
> +F: tools/perf/util/cs-etm*

Either way,

Acked-by: Will Deacon <[email protected]>

Thanks,

Will

2020-08-21 12:09:56

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

Em Fri, Aug 21, 2020 at 10:05:31AM +0100, Will Deacon escreveu:
> On Thu, Aug 20, 2020 at 11:55:10AM -0600, Mathieu Poirier wrote:
> > Add entries for perf tools elements related to the support of Arm CoreSight
> > and Arm SPE. Also lump in Arm and Arm64 architecture files to provide
> > coverage.
> >
> > Signed-off-by: Mathieu Poirier <[email protected]>
> > ---
> > V2:
> > - Completed fileset for SPE.
> > - Added Arm and Arm64 architecture files.
> >
> > MAINTAINERS | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index deaafb617361..e76f7bb014ce 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13569,12 +13569,18 @@ F: kernel/events/*
> > F: tools/lib/perf/
> > F: tools/perf/
> >
> > -PERFORMANCE EVENTS SUBSYSTEM ARM64 PMU EVENTS
> > +PERFORMANCE EVENTS SUBSYSTEM ARM64
>
> I'd probably prefer to go with TOOLING instead of SUBSYSTEM, since the
> kernel parts are covered by the "ARM PMU PROFILING AND DEBUGGING" entry.

Yeah, I think its appropriate to have TOOLING instead of SUBSYSTEM, that
is more commonly used when referring to the kernel.

I'm applying with that change, locally, with your and John's Acked-by,
please holler if that is somehow controversial.

- Arnaldo

> > R: John Garry <[email protected]>
> > R: Will Deacon <[email protected]>
> > +R: Mathieu Poirier <[email protected]>
> > +R: Leo Yan <[email protected]>
> > L: [email protected] (moderated for non-subscribers)
> > S: Supported
> > +F: tools/build/feature/test-libopencsd.c
> > +F: tools/perf/arch/arm*/
> > F: tools/perf/pmu-events/arch/arm64/
> > +F: tools/perf/util/arm-spe*
> > +F: tools/perf/util/cs-etm*
>
> Either way,
>
> Acked-by: Will Deacon <[email protected]>
>
> Thanks,
>
> Will

--

- Arnaldo