2020-08-19 20:01:08

by Adam Ford

[permalink] [raw]
Subject: [PATCH V3] ARM: dts: imx6q-logicpd: Fix broken PWM

The DTC doesn't like the default PWM settings, because it's expecting
three cells. This patch reduces adds the extra entry of 0 to the PWM
reference.

Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")

Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Adam Ford <[email protected]>
---
V2: Don't change HDMI

diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index 7a3d1d3e54a9..8f94364ba484 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -13,7 +13,7 @@ / {

backlight: backlight-lvds {
compatible = "pwm-backlight";
- pwms = <&pwm3 0 20000>;
+ pwms = <&pwm3 0 20000 0>;
brightness-levels = <0 4 8 16 32 64 128 255>;
default-brightness-level = <6>;
power-supply = <&reg_lcd>;
--
2.25.1


2020-08-23 02:57:40

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH V3] ARM: dts: imx6q-logicpd: Fix broken PWM

On Wed, Aug 19, 2020 at 02:59:44PM -0500, Adam Ford wrote:
> The DTC doesn't like the default PWM settings, because it's expecting
> three cells. This patch reduces adds the extra entry of 0 to the PWM
> reference.
>
> Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
>
> Reviewed-by: Fabio Estevam <[email protected]>
> Signed-off-by: Adam Ford <[email protected]>

Applied, thanks.