2020-08-23 07:25:05

by Dinghao Liu

Subject: [PATCH] NFC: st95hf: Fix memleak in st95hf_in_send_cmd

When down_killable() fails, skb_resp should be freed
just like when st95hf_spi_send() fails.

Signed-off-by: Dinghao Liu <[email protected]>
---
drivers/nfc/st95hf/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
index 9642971e89ce..457854765983 100644
--- a/drivers/nfc/st95hf/core.c
+++ b/drivers/nfc/st95hf/core.c
@@ -966,7 +966,7 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev,
rc = down_killable(&stcontext->exchange_lock);
if (rc) {
WARN(1, "Semaphore is not found up in st95hf_in_send_cmd\n");
- return rc;
+ goto free_skb_resp;
}

rc = st95hf_spi_send(&stcontext->spicontext, skb->data,
--
2.17.1

2020-08-25 00:37:41

by David Miller

Subject: Re: [PATCH] NFC: st95hf: Fix memleak in st95hf_in_send_cmd

From: Dinghao Liu <[email protected]>
Date: Sun, 23 Aug 2020 15:23:43 +0800

> When down_killable() fails, skb_resp should be freed
> just like when st95hf_spi_send() fails.
>
> Signed-off-by: Dinghao Liu <[email protected]>

Applied, thank you.