2020-08-24 17:22:23

by Alex Dewar

[permalink] [raw]
Subject: [PATCH RFC] mmc: sdhci-msm: enable compile-testing on !ARM

There seems to be no particular reason to only test for ARM, so allow
for build-testing on other platforms to increase coverage.

Build-tested on x86 with allyesconfig.

Signed-off-by: Alex Dewar <[email protected]>
---
Let me know if there is some extra dependency needed for COMPILE_TEST! I
don't want to break anything.
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f6c6eed5227a..7707f7385b5b 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -525,7 +525,7 @@ config MMC_ATMELMCI

config MMC_SDHCI_MSM
tristate "Qualcomm SDHCI Controller Support"
- depends on ARCH_QCOM || (ARM && COMPILE_TEST)
+ depends on ARCH_QCOM || COMPILE_TEST
depends on MMC_SDHCI_PLTFM
select MMC_SDHCI_IO_ACCESSORS
select MMC_CQHCI
--
2.28.0


2020-08-28 08:46:30

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH RFC] mmc: sdhci-msm: enable compile-testing on !ARM

On Mon, 24 Aug 2020 at 19:20, Alex Dewar <[email protected]> wrote:
>
> There seems to be no particular reason to only test for ARM, so allow
> for build-testing on other platforms to increase coverage.

Agree.

>
> Build-tested on x86 with allyesconfig.
>
> Signed-off-by: Alex Dewar <[email protected]>

I have applied this for next, let's see what the build bots reports, thanks!

Kind regards
Uffe


> ---
> Let me know if there is some extra dependency needed for COMPILE_TEST! I
> don't want to break anything.
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f6c6eed5227a..7707f7385b5b 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -525,7 +525,7 @@ config MMC_ATMELMCI
>
> config MMC_SDHCI_MSM
> tristate "Qualcomm SDHCI Controller Support"
> - depends on ARCH_QCOM || (ARM && COMPILE_TEST)
> + depends on ARCH_QCOM || COMPILE_TEST
> depends on MMC_SDHCI_PLTFM
> select MMC_SDHCI_IO_ACCESSORS
> select MMC_CQHCI
> --
> 2.28.0
>