2020-08-24 23:05:31

by Vineet Gupta

[permalink] [raw]
Subject: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds

Reported-by: kernel test robot <[email protected]>
Reported-by: Sebastian Andrzej Siewior <[email protected]>
Link: http://lists.infradead.org/pipermail/linux-snps-arc/2020-August/004032.html
Signed-off-by: Vineet Gupta <[email protected]>
---
arch/arc/plat-eznps/include/plat/ctop.h | 1 -
include/soc/nps/common.h | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
index a4a61531c7fb..77712c5ffe84 100644
--- a/arch/arc/plat-eznps/include/plat/ctop.h
+++ b/arch/arc/plat-eznps/include/plat/ctop.h
@@ -33,7 +33,6 @@
#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
-#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)

diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
index 9b1d43d671a3..8c18dc6d3fde 100644
--- a/include/soc/nps/common.h
+++ b/include/soc/nps/common.h
@@ -45,6 +45,12 @@
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422

+#ifndef AUX_IENABLE
+#define AUX_IENABLE 0x40c
+#endif
+
+#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
+
#ifndef __ASSEMBLY__

/* In order to increase compilation test coverage */
--
2.25.1


Subject: Re: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds

On 2020-08-24 16:01:49 [-0700], Vineet Gupta wrote:

A little of patch description wouldn't hurt. Especially since it is not
a simple move but IENABLE comes out of nowhere.

> Reported-by: kernel test robot <[email protected]>
> Reported-by: Sebastian Andrzej Siewior <[email protected]>
> Link: http://lists.infradead.org/pipermail/linux-snps-arc/2020-August/004032.html

That link gets lost if someone decides to recreate the pipermail archive
and you have no hint what it was. Using

Link: https://lkml.kernel.org/r/[email protected]

instead will instead give you the message-id in case lore dies or the
lkml.kernel.org redirect service goes into retirement.

> Signed-off-by: Vineet Gupta <[email protected]>
> ---
> arch/arc/plat-eznps/include/plat/ctop.h | 1 -
> include/soc/nps/common.h | 6 ++++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
> index a4a61531c7fb..77712c5ffe84 100644
> --- a/arch/arc/plat-eznps/include/plat/ctop.h
> +++ b/arch/arc/plat-eznps/include/plat/ctop.h
> @@ -33,7 +33,6 @@
> #define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
> #define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
> #define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
> -#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
> #define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
> #define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
>
> diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
> index 9b1d43d671a3..8c18dc6d3fde 100644
> --- a/include/soc/nps/common.h
> +++ b/include/soc/nps/common.h
> @@ -45,6 +45,12 @@
> #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
> #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422
>
> +#ifndef AUX_IENABLE
> +#define AUX_IENABLE 0x40c
> +#endif
> +
> +#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
> +
> #ifndef __ASSEMBLY__
>
> /* In order to increase compilation test coverage */

Sebastian

2020-08-25 18:08:29

by Vineet Gupta

[permalink] [raw]
Subject: [PATCH v2] irqchip/eznps: Fix build error for !ARC700 builds

eznps driver is supposed to be platform independent however it ends up
including stuff from inside arch/arc headers leading to rand config
build errors.

Fix this specific reported error as quick hacks as the correct fixes are
too much work:
- copy AUX_IENABLE from arch/arc header
- move CTOP_AUX_IACK from platform header

Reported-by: kernel test robot <[email protected]>
Reported-by: Sebastian Andrzej Siewior <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Vineet Gupta <[email protected]>
---
arch/arc/plat-eznps/include/plat/ctop.h | 1 -
include/soc/nps/common.h | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
index a4a61531c7fb..77712c5ffe84 100644
--- a/arch/arc/plat-eznps/include/plat/ctop.h
+++ b/arch/arc/plat-eznps/include/plat/ctop.h
@@ -33,7 +33,6 @@
#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
-#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)

diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
index 9b1d43d671a3..8c18dc6d3fde 100644
--- a/include/soc/nps/common.h
+++ b/include/soc/nps/common.h
@@ -45,6 +45,12 @@
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422

+#ifndef AUX_IENABLE
+#define AUX_IENABLE 0x40c
+#endif
+
+#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
+
#ifndef __ASSEMBLY__

/* In order to increase compilation test coverage */
--
2.25.1

Subject: Re: [PATCH v2] irqchip/eznps: Fix build error for !ARC700 builds

On 2020-08-25 11:05:18 [-0700], Vineet Gupta wrote:
> eznps driver is supposed to be platform independent however it ends up
> including stuff from inside arch/arc headers leading to rand config
> build errors.
>
> Fix this specific reported error as quick hacks as the correct fixes are
> too much work:
> - copy AUX_IENABLE from arch/arc header
> - move CTOP_AUX_IACK from platform header
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Sebastian Andrzej Siewior <[email protected]>
> Link: https://lkml.kernel.org/r/[email protected]
> Signed-off-by: Vineet Gupta <[email protected]>

Thank you.

Acked-by: Sebastian Andrzej Siewior <[email protected]>

in case it is not too late :)

Sebastian