2020-08-26 06:31:43

by Yue Haibing

Subject: [PATCH -next] btrfs: Remove unused variable 'fs_info'

fs/btrfs/volumes.c: In function ‘btrfs_rm_dev_replace_free_srcdev’:
fs/btrfs/volumes.c:2217:24: warning: unused variable ‘fs_info’ [-Wunused-variable]
struct btrfs_fs_info *fs_info = srcdev->fs_info;
^~~~~~~

Caused by commit 65237ee3b6b3 ("btrfs: get fs_info from device
in btrfs_rm_dev_replace_free_srcdev")

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
fs/btrfs/volumes.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index ec62fc0ec113..b775ed5d3737 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2214,7 +2214,6 @@ void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev)

void btrfs_rm_dev_replace_free_srcdev(struct btrfs_device *srcdev)
{
- struct btrfs_fs_info *fs_info = srcdev->fs_info;
struct btrfs_fs_devices *fs_devices = srcdev->fs_devices;

mutex_lock(&uuid_mutex);
--
2.17.1

2020-08-26 10:53:18

by David Sterba

Subject: Re: [PATCH -next] btrfs: Remove unused variable 'fs_info'

On Wed, Aug 26, 2020 at 02:27:52PM +0800, YueHaibing wrote:
> fs/btrfs/volumes.c: In function ‘btrfs_rm_dev_replace_free_srcdev’:
> fs/btrfs/volumes.c:2217:24: warning: unused variable ‘fs_info’ [-Wunused-variable]
> struct btrfs_fs_info *fs_info = srcdev->fs_info;
> ^~~~~~~
>
> Caused by commit 65237ee3b6b3 ("btrfs: get fs_info from device
> in btrfs_rm_dev_replace_free_srcdev")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Fixed in for-next, thanks.