2020-08-27 09:17:07

by Landen Chao (趙皎宏)

Subject: [PATCH] net: dsa: mt7530: fix advertising unsupported

1000baseT_Half

Remove 1000baseT_Half to advertise correct hardware capability in
phylink_validate() callback function.

Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
Signed-off-by: Landen Chao <[email protected]>
---
drivers/net/dsa/mt7530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 8dcb8a49ab67..238417db26f9 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1501,7 +1501,7 @@ static void mt7530_phylink_validate(struct dsa_switch *ds, int port,
phylink_set(mask, 100baseT_Full);

if (state->interface != PHY_INTERFACE_MODE_MII) {
- phylink_set(mask, 1000baseT_Half);
+ /* This switch only supports 1G full-duplex. */
phylink_set(mask, 1000baseT_Full);
if (port == 5)
phylink_set(mask, 1000baseX_Full);
--
2.17.1

2020-08-28 01:24:21

by Andrew Lunn

Subject: Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

On Thu, Aug 27, 2020 at 05:15:47PM +0800, Landen Chao wrote:
> 1000baseT_Half
>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-08-28 03:19:09

by Florian Fainelli

Subject: Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

On 8/27/2020 2:15 AM, Landen Chao wrote:
> 1000baseT_Half

Looks like this part of the commit subject spilled into the commit message.

>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-28 13:57:28

by David Miller

Subject: Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

From: Landen Chao <[email protected]>
Date: Thu, 27 Aug 2020 17:15:47 +0800

> 1000baseT_Half
>
> Remove 1000baseT_Half to advertise correct hardware capability in
> phylink_validate() callback function.
>
> Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> Signed-off-by: Landen Chao <[email protected]>

Applied and queued up for -stablel, with Subject line spillage
fixed, thank you.