2020-08-27 09:31:19

by Xu Wang

Subject: [PATCH] scsi: qedi: Remove redundant null check

Because kfree_skb already checked NULL skb parameter,
so the additional check is unnecessary, just remove it.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/scsi/qedi/qedi_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 6f038ae5efca..e42437ec23a8 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -789,8 +789,7 @@ static void qedi_ll2_free_skbs(struct qedi_ctx *qedi)
spin_lock_bh(&qedi->ll2_lock);
list_for_each_entry_safe(work, work_tmp, &qedi->ll2_skb_list, list) {
list_del(&work->list);
- if (work->skb)
- kfree_skb(work->skb);
+ kfree_skb(work->skb);
kfree(work);
}
spin_unlock_bh(&qedi->ll2_lock);
--
2.17.1

2020-09-09 02:11:22

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedi: Remove redundant null check

On Thu, 27 Aug 2020 09:26:06 +0000, Xu Wang wrote:

> Because kfree_skb already checked NULL skb parameter,
> so the additional check is unnecessary, just remove it.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qedi: Remove redundant NULL check
https://git.kernel.org/mkp/scsi/c/9535f2152ace

--
Martin K. Petersen Oracle Linux Engineering