2020-08-27 19:06:35

by Ralph Campbell

Subject: [PATCH] mm/test: use the new SKIP() macro

Some tests might not be able to be run if resources like huge pages are
not available. Mark these tests as skipped instead of simply passing.

Signed-off-by: Ralph Campbell <[email protected]>
---

This applies to linux-mm and is for Andrew Morton's tree.

tools/testing/selftests/vm/hmm-tests.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c
index 93fc5cadce61..0a28a6a29581 100644
--- a/tools/testing/selftests/vm/hmm-tests.c
+++ b/tools/testing/selftests/vm/hmm-tests.c
@@ -680,7 +680,7 @@ TEST_F(hmm, anon_write_hugetlbfs)

n = gethugepagesizes(pagesizes, 4);
if (n <= 0)
- return;
+ SKIP(return, "Huge page size could not be determined");
for (idx = 0; --n > 0; ) {
if (pagesizes[n] < pagesizes[idx])
idx = n;
@@ -694,7 +694,7 @@ TEST_F(hmm, anon_write_hugetlbfs)
buffer->ptr = get_hugepage_region(size, GHR_STRICT);
if (buffer->ptr == NULL) {
free(buffer);
- return;
+ SKIP(return, "Huge page could not be allocated");
}

buffer->fd = -1;
--
2.20.1

2020-08-28 11:41:41

by Jason Gunthorpe

Subject: Re: [PATCH] mm/test: use the new SKIP() macro

On Thu, Aug 27, 2020 at 12:04:00PM -0700, Ralph Campbell wrote:
> Some tests might not be able to be run if resources like huge pages are
> not available. Mark these tests as skipped instead of simply passing.
>
> Signed-off-by: Ralph Campbell <[email protected]>
> ---
>
> This applies to linux-mm and is for Andrew Morton's tree.
>
> tools/testing/selftests/vm/hmm-tests.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason