2020-08-28 21:36:52

by Thomas Preston

Subject: [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17

Hi again,
Second round of these mcp23s03 driver fixups.

Changes since v1:
- Split up the fixups patch.
- I'm pretty certain the "mcp23x16" structs are typos, so I put it as
0001, because the second patch doesn't really make sense without it.
- I lost the `(MCP_GPIO << 1) + 1` changes because the regmap handles
GPIOB 0x13 with `.val_bits = 16`.
- Dropped the interrupt-controller changes.

Thanks again,
Thomas

Thomas Preston (2):
pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser
pinctrl: mcp23s08: Fix mcp23x17 precious range

drivers/pinctrl/pinctrl-mcp23s08.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

--
2.26.2

2020-08-30 17:45:50

by Andy Shevchenko

Subject: Re: [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17

On Sat, Aug 29, 2020 at 12:33 AM Thomas Preston
<[email protected]> wrote:
>
> Hi again,
> Second round of these mcp23s03 driver fixups.

v2 makes sense to me, thanks!
Reviewed-by: Andy Shevchenko <[email protected]>

> Changes since v1:
> - Split up the fixups patch.
> - I'm pretty certain the "mcp23x16" structs are typos, so I put it as
> 0001, because the second patch doesn't really make sense without it.
> - I lost the `(MCP_GPIO << 1) + 1` changes because the regmap handles
> GPIOB 0x13 with `.val_bits = 16`.
> - Dropped the interrupt-controller changes.
>
> Thanks again,
> Thomas
>
> Thomas Preston (2):
> pinctrl: mcp23s08: Fix mcp23x17_regmap initialiser
> pinctrl: mcp23s08: Fix mcp23x17 precious range
>
> drivers/pinctrl/pinctrl-mcp23s08.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> --
> 2.26.2
>


--
With Best Regards,
Andy Shevchenko

2020-09-12 09:33:22

by Linus Walleij

Subject: Re: [PATCH v2 0/2] pinctrl: mcp23s08: Fixups for mcp23x17

On Fri, Aug 28, 2020 at 11:32 PM Thomas Preston
<[email protected]> wrote:

> Hi again,
> Second round of these mcp23s03 driver fixups.
>
> Changes since v1:
> - Split up the fixups patch.
> - I'm pretty certain the "mcp23x16" structs are typos, so I put it as
> 0001, because the second patch doesn't really make sense without it.
> - I lost the `(MCP_GPIO << 1) + 1` changes because the regmap handles
> GPIOB 0x13 with `.val_bits = 16`.
> - Dropped the interrupt-controller changes.

Patches applied!

Yours,
Linus Walleij