2020-08-28 11:33:04

by Robert Chiras (OSS)

Subject: [PATCH 2/5] dt-bindings: display/bridge: nwl-dsi: Document video_pll clock

From: Robert Chiras <[email protected]>

Add documentation for a new clock 'video_pll'.

Signed-off-by: Robert Chiras <[email protected]>
---
Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
index 04099f5..8b5741b 100644
--- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
@@ -37,6 +37,8 @@ properties:
- description: TX_ESC clock (used in escape mode)
- description: PHY_REF clock
- description: LCDIF clock
+ - description: VIDEO_PLL clock (used to set the the PLL clock feeding both
+ phy_ref and DC pixel clock to a convenient rate)

clock-names:
items:
@@ -45,6 +47,7 @@ properties:
- const: tx_esc
- const: phy_ref
- const: lcdif
+ - const: video_pll

mux-controls:
description:
--
2.7.4

2020-08-28 21:43:30

by Rob Herring (Arm)

Subject: Re: [PATCH 2/5] dt-bindings: display/bridge: nwl-dsi: Document video_pll clock

On Fri, 28 Aug 2020 14:13:29 +0300, Robert Chiras (OSS) wrote:
> From: Robert Chiras <[email protected]>
>
> Add documentation for a new clock 'video_pll'.
>
> Signed-off-by: Robert Chiras <[email protected]>
> ---
> Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: mipi_dsi@30a00000: clocks: [[4294967295, 163], [4294967295, 244], [4294967295, 245], [4294967295, 164], [4294967295, 128]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: mipi_dsi@30a00000: clock-names: ['core', 'rx_esc', 'tx_esc', 'phy_ref', 'lcdif'] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml


See https://patchwork.ozlabs.org/patch/1353197

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.